Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace computeHash with ComputeMD5; resolves #333. #338
+25
−31
Conversation
ruebot
requested review from
ianmilligan1 and
jrwiebe
Aug 7, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Aug 7, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=========================================
Coverage ? 74.95%
=========================================
Files ? 39
Lines ? 1122
Branches ? 197
=========================================
Hits ? 841
Misses ? 214
Partials ? 67
Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Aug 7, 2019
Reviewed with both docs as well as the new |
jrwiebe
merged commit 9623c7a
into
master
Aug 7, 2019
jrwiebe
deleted the
issue-333
branch
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedAug 7, 2019
•
edited
GitHub issue(s): #333
What does this Pull Request do?
Replace
computeHash
withComputeMD5
.How should this be tested?
Additional Notes:
This seems sloppy, but if y'all don't think it is, then it isn't😉