Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates for https://github.com/archivesunleashed/aut/pu… #83

Merged
merged 2 commits into from Jun 18, 2020

Conversation

@ruebot
Copy link
Member

ruebot commented Jun 18, 2020

…ll/375

`export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64` or on macOS it might be
`export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home`.
`export JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64` or on macOS it might be
`export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.11.0_74.jdk/Contents/Home`.

This comment has been minimized.

Copy link
@ruebot

ruebot Jun 18, 2020

Author Member

@ianmilligan1 can you double these two lines on macOS?

This comment has been minimized.

Copy link
@ianmilligan1

ianmilligan1 Jun 18, 2020

Member

On mine it's

export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk-11.0.5.jdk/Contents/Home

For Java 8 it was similar to what you had before, I think the naming convention may have changed. 🤷‍♂️

@ruebot
Copy link
Member Author

ruebot commented Jun 18, 2020

@ianmilligan1 @SamFritz I think this is all that needs to be updated in the documentation. Can you double-check and make sure?

@ruebot ruebot requested review from ianmilligan1 and SamFritz Jun 18, 2020
Copy link
Member

ianmilligan1 left a comment

Looks good to me; would just consider making the change to the JAVA_HOME example as noted in comments.

@ianmilligan1
Copy link
Member

ianmilligan1 commented Jun 18, 2020

Can you double-check and make sure?

And yes, just did a search and a walk through, I think you've updated everywhere that needs to be updated!

@ianmilligan1 ianmilligan1 merged commit 8e94cf9 into docusaurus Jun 18, 2020
3 checks passed
3 checks passed
delivery
Details
delivery
Details
Travis CI - Pull Request Build Passed
Details
@ianmilligan1 ianmilligan1 deleted the aut-pr-375 branch Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.