Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement typo fixes from @SamFritz, resolves #71 #86

Merged
merged 4 commits into from Jun 22, 2020
Merged

Conversation

@ianmilligan1
Copy link
Member

ianmilligan1 commented Jun 22, 2020

Implementing suggestions from #71 - thanks @SamFritz! As they apply to both these docs and the next, am applying to both version-0.80.0 and the docs directories.

@ianmilligan1 ianmilligan1 requested review from ruebot and SamFritz Jun 22, 2020
@ruebot
ruebot approved these changes Jun 22, 2020
Copy link
Member

SamFritz left a comment

Thanks @ianmilligan1 for staging fixes!

Just have two minor changes for binary sections: "audio files" should replace "images" in line 27 and "audio" to "audio files" for consistency

@@ -27,7 +27,7 @@ df.select($"url", $"filename", $"extension", $"mime_type_web_server", $"mime_typ

Will extract all following information from images in a web collection:

This comment has been minimized.

Copy link
@SamFritz

SamFritz Jun 22, 2020

Member

sorry, I should have included line # to make things easier - "audio files" should replace "image" in line 27

@@ -26,7 +26,7 @@ df.select($"url", $"filename", $"extension", $"mime_type_web_server", $"mime_typ

Will extract all following information from images in a web collection:

This comment has been minimized.

Copy link
@SamFritz

SamFritz Jun 22, 2020

Member

sorry, I should have included line # to make things easier - "audio files" should replace "image" in line 27

@@ -89,15 +89,13 @@ df = archive.audio()
df.show()
```

Will extract all following information from images in a web collection:
Will extract all following information from audio in a web collection:

This comment has been minimized.

Copy link
@SamFritz

SamFritz Jun 22, 2020

Member

"audio files" for consistency?

@@ -88,15 +88,13 @@ df = archive.audio()
df.show()
```

Will extract all following information from images in a web collection:
Will extract all following information from audio in a web collection:

This comment has been minimized.

Copy link
@SamFritz

SamFritz Jun 22, 2020

Member

"audio files" for consistency?

@SamFritz
Copy link
Member

SamFritz commented Jun 22, 2020

Thanks @ianmilligan1!

@ianmilligan1 ianmilligan1 merged commit 2c7a315 into docusaurus Jun 22, 2020
4 checks passed
4 checks passed
checks
Details
delivery
Details
delivery
Details
gh-release
Details
@ianmilligan1 ianmilligan1 deleted the copyedits branch Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.