Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DomainFrequencyExtractor should remove WWW prefix #456

Closed
ruebot opened this issue Apr 27, 2020 · 0 comments
Closed

DomainFrequencyExtractor should remove WWW prefix #456

ruebot opened this issue Apr 27, 2020 · 0 comments
Assignees
@ruebot
Labels
App Scala bug

Comments

@ruebot
Copy link
Member

@ruebot ruebot commented Apr 27, 2020

Currently the DomainFrequencyExtractor does not remove the WWW prefix. We should include RemovePrefixWWWDF as well.

aut/src/main/scala/io/archivesunleashed/app/DomainFrequencyExtractor.scala

Lines 30 to 38 in 9b1aae9

def apply(d: DataFrame): Dataset[Row] = {
val spark = SparkSession.builder().master("local").getOrCreate()
// scalastyle:off
import spark.implicits._
// scalastyle:on
d.groupBy(ExtractDomainDF($"url").as("domain"))
.count()
.sort($"count".desc)
}

@ruebot ruebot self-assigned this Apr 27, 2020
ruebot added a commit that referenced this issue Apr 27, 2020
@ruebot
Add RemovePrefixWWWDF to DomainFrequencyExtractor.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
b831eb3 
- Resolves #456
- Update test
@ruebot ruebot mentioned this issue Apr 27, 2020
Merged
ianmilligan1 pushed a commit that referenced this issue Apr 27, 2020
@ruebot
Add RemovePrefixWWWDF to DomainFrequencyExtractor. (#457)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0f3d732 
- Resolves #456
- Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruebot ruebot

Labels
App Scala bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add RemovePrefixWWWDF to DomainFrequencyExtractor.
1 participant
@ruebot
You can’t perform that action at this time.