Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RDD suffixes on file, class, and object names. #479

Merged
merged 3 commits into from Jun 1, 2020
Merged

Remove RDD suffixes on file, class, and object names. #479

merged 3 commits into from Jun 1, 2020
+134 −411

Conversation

@ruebot
Copy link
Member

ruebot commented Jun 1, 2020 •
edited

GitHub issue(s): #468

What does this Pull Request do?

Remove RDD suffixes on file, class, and object names.

  • Remove all the RDD suffixes added previously
  • Rename image_graph to imagegraph (Python)
  • Rename GetExtensionMime to GetExtensionMIME (Scala)
  • Remove textFiles (Scala)
  • Remove text_files (Python)
  • Remove TextFilesInformationExtractor
  • Rename files all affected files as needed
  • Update tests as needed

How should this be tested?

  • TravisCI should do it
  • But, a good sniff test would be good as well.

Additional Notes:

  • Since there is so much documentation changes, I'll get the documentation updated on the docusaurus updates I'm working on. I'll try and push up a branch there with the changes today.
  • Notebooks will need to be updated. I'll try and get that updated later today as well
@ruebot
Remove RDD suffixes on file, class, and object names.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
c1b8298 
- Remove all the RDD suffixes added previously
- Rename presentationProgramFiles to presentationProgram (Scala)
- Rename wordProcessorFiles to wordProcessor (Scala)
- Rename image_graph to imagegraph (Python)
- Rename textFiles to textfiles (Scala)
- Rename text_files to textfiles (Python)
- Rename files all affected files as needed
- Update tests as needed
@ruebot ruebot requested review from lintool and ianmilligan1 Jun 1, 2020
ruebot added a commit to archivesunleashed/aut-docs that referenced this pull request Jun 1, 2020
@ruebot
Documentation updates for archivesunleashed/aut#479
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
15726a9
@ruebot
Copy link
Member Author

ruebot commented Jun 1, 2020

Documentation updates are over here. They'll get in the website when the time comes.
@codecov
Copy link

codecov bot commented Jun 1, 2020 •
edited

Codecov Report

Merging #479 into master will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   83.88%   83.69%   -0.20%     
==========================================
  Files          44       43       -1     
  Lines        1297     1245      -52     
  Branches      250      239      -11     
==========================================
- Hits         1088     1042      -46     
  Misses         80       80              
+ Partials      129      123       -6
@ruebot
Remove textFiles, and put wordProcessFiles/presentatioProgramFiles back.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
b965f26
@ruebot ruebot mentioned this pull request Jun 1, 2020
Closed
ruebot added a commit to archivesunleashed/aut-docs that referenced this pull request Jun 1, 2020
@ruebot
More updates for archivesunleashed/aut#479
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
a0f351b
ruebot added a commit to ruebot/aut-docs-redux that referenced this pull request Jun 1, 2020
@ruebot
Updates for archivesunleashed/aut#479
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
d2f80fa
@lintool
lintool reviewed Jun 1, 2020
View changes
Copy link
Member

lintool left a comment

I think I caught a name inconsistency?
src/main/scala/io/archivesunleashed/matchbox/GetExtensionMime.scala Outdated Show resolved Hide resolved
@ruebot
GetExtensionMime -> GetExtensionMIME.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
5de7359
@ianmilligan1
ianmilligan1 approved these changes Jun 1, 2020
View changes
@lintool
lintool approved these changes Jun 1, 2020
View changes
Copy link
Member

lintool left a comment

lgtm!
@ianmilligan1 ianmilligan1 merged commit 1ac97ef into master Jun 1, 2020
2 of 3 checks passed
2 of 3 checks passed
codecov/project 83.69% (+-0.20%) compared to 8037745
Details
codecov/patch 100.00% of diff hit (target 83.88%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-468-scala branch Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lintool lintool

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ruebot @lintool @ianmilligan1
You can’t perform that action at this time.