Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "personal communication" to remaining APA locales #4866

Merged
merged 2 commits into from Jun 20, 2020

Conversation

@bwiernik
Copy link
Contributor

bwiernik commented Jun 14, 2020

Found examples of usage for these. No examples for Khmer, but the main locale file for that is basically empty anyway.

Found examples of usage for these. No examples for Khmer, but the main locale file for that is basically empty anyway.
@csl-bot
Copy link

csl-bot commented Jun 14, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Jun 14, 2020

😟 There are some issues with your submission.

6 tests failed

apa: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "266:3: FATAL: Extra content at the end of the document"]].empty?` to return true, got false

apa-cv: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "266:3: FATAL: Extra content at the end of the document"]].empty?` to return true, got false

apa-single-spaced: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "266:3: FATAL: Extra content at the end of the document"]].empty?` to return true, got false

apa-with-abstract: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "266:3: FATAL: Extra content at the end of the document"]].empty?` to return true, got false

apa-no-ampersand: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "266:3: FATAL: Extra content at the end of the document"]].empty?` to return true, got false

apa-annotated-bibliography: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "266:3: FATAL: Extra content at the end of the document"]].empty?` to return true, got false

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Jun 14, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

apa-annotated-bibliography.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa-cv.csl (modified style; unchanged output for sample items)
CSL search by example. (2012). http://editor.citationstyles.org/searchByExample/ Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press. Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8

CSL search by example. (2012). http://editor.citationstyles.org/searchByExample/
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
apa-no-ampersand.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., and Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., and Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall and D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa-single-spaced.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa-with-abstract.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
This article presents a practical roadmap for scholarly data repositories to implement data citation in accordance with the Joint Declaration of Data Citation Principles, a synopsis and harmonization of the recommendations of major science policy bodies. The roadmap was developed by the Repositories Expert Group, as part of the Data Citation Implementation Pilot (DCIP) project, an initiative of FORCE11.org and the NIH-funded BioCADDIE (https://biocaddie.org) project. The roadmap makes 11 specific recommendations, grouped into three phases of implementation: a) required steps needed to support the Joint Declaration of Data Citation Principles, b) recommended steps that facilitate article/data publication workflows, and c) optional steps that further improve data citation support provided by data repositories. We describe the early adoption of these recommendations 18 months after they have first been published, looking specifically at implementations of machine-readable metadata on dataset landing pages.

Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
@adam3smith adam3smith merged commit 2f70b14 into citation-style-language:master Jun 20, 2020
@adam3smith
Copy link
Member

adam3smith commented Jun 20, 2020

Thanks!

@bwiernik bwiernik deleted the bwiernik:apa-patch branch Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.