Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate uclouvain-centre-charles-de-visscher-pour-le-droit-internation… #4871
Conversation
…al-et-europeen.csl These changes were made by a student after he received feedback from a group who used this style. He then submitted this updated version of the style to me. It's been so long since I worked on this code, I'd be very happy if someone could help me and see if everything seems OK.
This comment has been minimized.
This comment has been minimized.
anfourny
commented on uclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen.csl
in 6357274
Jun 16, 2020
Pretty sure the suffix should be ", " with an extra space |
csl-bot
commented
Jun 16, 2020
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
csl-bot
commented
Jun 16, 2020
2 tests faileduclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen: must validate against the CSL 1.0.1 schema
uclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen: may not have any unused macros
Please check the test report for details. |
…al-et-europeen.csl
csl-bot
commented
Jun 17, 2020
Below are some sample citations generated based on your proposed changes: uclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen.csl (modified style; unchanged output for sample items); . |
csl-bot
commented
Jun 20, 2020
Below are some sample citations generated based on your proposed changes: uclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen.csl (modified style; unchanged output for sample items); . |
@adam3smith, LGTM. |
Thanks! (I changed the code for bill/legislation to what I assume was intended: testing match="all" on more than one type will always return false, so that didn't make sense as written) |
Thank you guys so much for your help! |
anfourny commentedJun 16, 2020
…al-et-europeen.csl
These changes were made by a student after he received feedback from a group who used this style. He then submitted this updated version of the style to me. It's been so long since I worked on this code, I'd be very grateful if someone could help me and see if everything seems OK.
Thanks!