Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix author names for new(ish) layout #2173
Merged
+105
−96
Conversation
|
Thanks! |
| if (baseNode) { | ||
| var authors = ZU.xpath(baseNode, './/span[@id="artistBlurb"]/a'); | ||
| authors = ZU.xpath(baseNode, './/span[@id="artistBlurb"]/a'); |
This comment has been minimized.
This comment has been minimized.
dstillman
May 10, 2020
Member
Just to note, unless a variable is used outside a block, we prefer to use let inside the block rather than var outside — lets you easily know that a variable's scope is limited to the current block. (We also try to avoid multi-variable initialization, since it makes for worse diffs.)
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
adam3smith commentedMay 10, 2020
https://forums.zotero.org/discussion/82934/connector-on-amazon-not-saving-authors-names#latest
(no tests from that thread since issue also affects existing tests)