Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove variable call from macro #33
Merged
+0
−1
Conversation
|
Thanks! That sentence (or a version of it) was intended for the specifications, though. |
|
Did you fix it (by squash merging)?
… |
|
I think that worked correctly, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bdarcus commentedJun 27, 2020
I'm not really sure if this is right, but ...
Except in rare cases, macros that render more than one element should
be avoided as sort keys, as they can lead to unexpected sorting in edge
cases. Instead, use their elements as individual, consecutive sort keys.
Closes #31