Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined macro in test case #23

Closed
jgm opened this issue Jun 3, 2020 · 1 comment
Closed

undefined macro in test case #23

jgm opened this issue Jun 3, 2020 · 1 comment
Assignees

Comments

@jgm
Copy link

@jgm jgm commented Jun 3, 2020

In name_SubsequentAuthorSubstituteSingleField.txt there is a reference to a contributors-short macro, which is not defined there.
Is that intentional?
Is there a specified behavior when an undefined macro is called? Should a processor return empty output, or should an error or warning be produced?

adam3smith added a commit that referenced this issue Jun 3, 2020
Fixes #23
@adam3smith
Copy link
Member

@adam3smith adam3smith commented Jun 3, 2020

Is that intentional?

No. Fix forthcoming (the undefined macros are all in the citation section which isn't used in the test at all, which is why it's presumably passing in other citeprocs)

Is there a specified behavior when an undefined macro is called? Should a processor return empty output, or should an error or warning be produced?

I don't know; certainly not in the specs. citeproc-js returns empty, but I'm ambivalent about that: it makes style bugs less severe, but also harder to track down (e.g. a typo in a macro call which just make something not appear rather than throw an easily traceable error).

On the style repository, we have CI tests to prevent calls to undefined macros, so at a minimum deciding to throw an error for such a call wouldn't be likely to cause much problems.

@bdarcus -- if you want to discuss whether to prescribe processor behavior on this, that should probably be a new issue. This one will close once my PR is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.