Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop to version 0.83.0 #119
Merged
+1
−1
Conversation
codecov
bot
commented
May 12, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 34 34
=========================================
Hits 34 34 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
depfu bot commentedMay 12, 2020
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
0.83.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 72 commits:
Cut 0.83
Merge pull request #7951 from jethrodaniel/rakefile
add `rakefile` (lowercase) to default config
Tweak a changelog entry
Remove dependency on `jaro_winkler`
Use DidYouMean
Change find_similar_name to a module_function
Simplify NameSimilarity.find_similar_name
Add new `Layout/EmptyLineAroundAttributeAccessor` cop
Mark unsafe for `Style/OptionalArguments` cop
Merge pull request #7935 from koic/fix_false_positive_for_style_guard_clause
[Fix #7928] Fix a false positive for `Style/GuardClause`
Merge pull request #7934 from koic/support_autocorrect_for_lint_ensure_return
Merge pull request #7932 from koic/fix_false_message_for_guard_clause
Support autocorrection for `Lint/EnsureReturn`
[Fix #7928] Fix a false message for `Style/GuardClause`
Merge pull request #7925 from koic/support_autocorrection_for_layout_condition_position]
Support autocorrection for `Layout/ConditionPosition`
Merge pull request #7910 from koic/support_autocorrect_for_parentheses_as_grouped_expression
Support autocorrection for `Lint/ParenthesesAsGroupedExpression`
Tweak the changelog
Merge pull request #7907 from koic/add_allow_comments_to_lint_empty_when
[Fix #3696] Add `AllowComments` option to `Lint/EmptyWhen` cop
Implement Style/SlicingWithRange cop
Support autocorrection for `Style/IfWithSemicolon`
[Fix #7936] Mark Lint/BooleanSymbol as unsafe (#7941)
Add required Ruby version to generated cops manual
Merge pull request #7897 from tejasbubane/generator-version-added
Merge pull request #7930 from jonas054/4245_arbitrary_files_on_command_line
Merge pull request #7913 from koic/false_positive_for_lint_literal_as_condition
Fix a false positive for `Lint/LiteralAsCondition`
Merge pull request #7909 from koic/fix_a_false_positive_for_parentheses_as_grouped_expression
Update Change log to link the breaking change
[Fix 4245] Add --only-recognized-file-types and change default
Extract common test code into shared examples
Add mode parameter to TargetFinder#find()
Merge pull request #7939 from jeffcarbs/fix-frozen-string-literal-comment
[Fix #7929] Accept frozen_string_literal anywhere in leading comment lines
Fix a false positive for `Lint/ParenthesesAsGroupedExpression`
Merge pull request #7926 from jonas054/7885_IfUnlessModifier_with_tab_indentation
[Fix #7885] Re-use LineLengthHelp for statement modifiers
Merge pull request #7923 from jonas054/7390_cop_enabled_overrides_department
[Fix #7390] Override disabled department for enabled cops
Merge pull request #7918 from koic/support_autocorrect_for_ambiguous_operator
Support autocorrection for `Lint/AmbiguousOperator`
Merge pull request #7920 from jonas054/595_erb_processing_of_configuration
[Fix #595] Add ERB pre-processing for configuration files
Allow Generator to take version_added parameter
Merge pull request #7917 from koic/support_autocorrect_for_useless_access_modifier
Support autocorrection for `Lint/UselessAccessModifier`
Support autocorrection for `Lint/AmbiguousRegexpLiteral`
Use https instead of http for semver.org
Merge pull request #7901 from koic/fix_an_infinite_loop_error_for_space_around_operators
[Fix #7899] Fix an infinite loop error for `Layout/SpaceAroundOperators`
Merge pull request #7903 from koic/fix_incorrect_autocorrect_for_hash_transform_methods
Fix an incorrect autocorrect for hash transform methods
Fix an error when running `--only` or `--except` options
Display `N/A` for pending cop warnings without `VersionAdded` specified
Replace AppVeyor with GitHub Actions (#7893)
Add .simplecov to rubocop default include list
Merge pull request #7896 from hugopeixoto/patch-1
Fix semantic versioning link
[Fix #7635] Fix a false positive for `Style/MultilineWhenThen`
Merge pull request #7892 from krzysiek1507/patch-1
Fix the command flags table
[Fix #7094] Clarify alignment in MultilineOperationIndentation
[Fix #7881] Call act_on_options earlier in CLI#run()
Merge pull request #7888 from jonas054/7790_parallel_disabling_other_options
[Fix #7790] Set options in ConfigLoader earlier
[Fix #7860] Change `AllowInHeredoc` option of `Layout/TrailingWhitespace` to `true`
Merge pull request #7882 from rafaelfranca/rm-fix-allow-constant
Fix `Style/CaseEquality` when `AllowOnConstant` is `true`
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands