Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop to version 0.84.0 #120
Merged
Conversation
codecov
bot
commented
May 22, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 34 34
=========================================
Hits 34 34 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
depfu bot commentedMay 22, 2020
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
0.84.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 50 commits:
Fix the release notesCut 0.84Add doc for disabling comment style[Fix #7993] Fix a false positive for `Migration/DepartmentName`Add a .dir-locals.elRemove unneeded let for specs using :config shared environmentRefactor `config` shared context. Simplify some specs.Spec: remove trailing whitespaceLint/SuppressedException: Explicit AllowComments config in specLint/EmptyWhen Add explicit config that is differing from default [#7999]Add rake check_commit and check_commit:auto_correctAllow args in SpecRunner task[Fix #7991] Fix an error for `Layout/EmptyLinesAroundAttributeAccessor`[Fix #7886] Look for comments between rescue and end[Docs] Improve a bit the structure of the cop development docs[Docs] Improve the automated code reviews section[Docs] Replace mentions of Salt with GitHub Sponsors[Docs] Extend the explanation of --safe-auto-correctFix a typoTweak a changelog entryFix option names in the changelogFix the broken docs buildAdd `EnforcedStyle` for `Style/DoubleNegation` cop[Fix #7976] Add ignore options for `Layout/EmptyLinesAroundAttributeAccessor`[Docs] Improve some wording in the "Development" section of the docs[Docs] Update some references to reflect the extraction of rubocop-astUpdate `VersionChanged` from 1.0 to 0.84Fix typoesRemove unneeded conditionals with latest rubocop-ast[Fix rubocop-hq/rubocop-ast#7] Reimport error from rubocop-ast[Fix rubocop-hq/rubocop-ast#7] Create aliases for AST::NodePattern, ProcessedSource and Token[Fix rubocop-hq/rubocop-ast#7] Import ProcessedSource#comment_config and related method from rubocop-ast[Fix #7972] Fix an incorrect autocorrect for `Style/HashSyntax` (#7973)Add new `Lint/DeprecatedOpenSSLConstant` copSupport any expression as the start index in Style/SlicingWithRange (#7967)Improve FrozenStringLiteralComment autocorrection.Merge pull request #7964 from marcandre/fix_disableFix calculation in disable_offense.[Fix #7962] Fix a false positive for `Lint/ParenthesesAsGroupedExpression`Have `rubocop -V` output rubocop-ast's versionBump required rubocop-astUpdate links to rubocop-ast [doc] [ci skip]Amend Changelog for [#7735] [doc] [ci skip]Change enforced style to `conditionals` for `Style/AndOr`Require rubocop-ast gemSimplify spec furtherTweak spec to define method only onceSimplify specs[Fix #7953] Fix an error for `Lint/AmbiguousOperator`Change the max line length of `Layout/LineLength` to 120Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands