Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop-rspec to version 1.40.0 #127
Merged
Conversation
codecov
bot
commented
Jun 12, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 34 34
=========================================
Hits 34 34 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
depfu bot commentedJun 12, 2020
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
1.40.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 49 commits:
Merge pull request #927 from rubocop-hq/releaseBump version to v1.40.0Merge pull request #928 from rubocop-hq/add-andry-to-hall-of-fameAdd Andrew to the hall of fameMerge pull request #925 from andrykonchin/speedup-subject-stub-copMerge pull request #721 from rubocop-hq/add-metadataRSpec/SubjectStub. Code review. Remove excessive condition and fix searching of outer example groupRevert "RSpec/SubjectStub. Code review. Use #on_top_level_describe instead of #on_block callback"Tagging cops as unsafe for auto-correctionUpdate PR template with version requirementUnify key order in the configAdd recently added cops' versionsAdd cop metadataRSpec/SubjectStub. Code review. Use #on_top_level_describe instead of #on_block callbackRSpec/SubjectStub. Code review. Handle case with several explicit subjects in example groupRSpec/SubjectStub. Code review. Refactor #find_all_named_subjects methodMerge pull request #924 from rubocop-hq/fix-leaky-constant-declarationsRSpec/SubjectStub. Refactor and decrease complexityFix leaking constant[Docs] Fix syntax highlighting of some code snippetsMerge pull request #917 from rolfschmidt/followup-869Move some text from the README to the docsFix `RSpec/FilePath` detection across sibling directories.Merge pull request #915 from rubocop-hq/cleanup-workaroundSimplify manual generationCleanup workaroundMerge pull request #920 from robotdana/repeated-example-group-body-with-constAllow identical body with distinct described_classConvert the docs to AsciiDoc and AntoraMerge pull request #912 from zdennis/features/file-path-cop-spec-suffix-onlyMerge pull request #914 from rubocop-hq/fix-edge-rubocop-0.84-offences-2Remove ExampleWording specs for empty configRemove explicit `subject(:cop)` from specsRemove default configuration from specsFix specsMerge pull request #913 from rubocop-hq/fix-edge-rubocop-0.84-offencesFix an offence conflict to appease both copsFix RuboCop 0.84 offencesSort alphabeticallyDon't give in to the mainstreamAdd SpecSuffixOnly option to RSpec/FilePath copMerge pull request #909 from twalpole/capybara_visibility_matchersMerge pull request #905 from tejasbubane/generator-version-addedUse rubocop-rspec's version while generating new copSupport multiple matchers for Capybara/VisibilityMatcher copMerge pull request #910 from tejasbubane/variable-definition-copAdd new `RSpec/VariableDefinition` copMerge pull request #907 from tejasbubane/rspec-variable-name-copAdd new `RSpec/VariableName` copDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands