Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop-rspec to version 1.37.1 #100

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@depfu
Copy link
Contributor

depfu bot commented Dec 20, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (~> 1.36.0 → ~> 1.37.1) · Repo · Changelog

Release Notes

1.37.1

  • Improve message and description of FactoryBot/FactoryClassName. (@ybiquitous)
  • Fix FactoryBot/FactoryClassName to ignore Hash and OpenStruct. (@jfragoulis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 14 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Dec 20, 2019
@ruebot ruebot merged commit 2a9eb9a into master Dec 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.37.1 branch Dec 20, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #100 into master will increase coverage by 8.82%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #100      +/-   ##
========================================
+ Coverage   91.17%   100%   +8.82%     
========================================
  Files           5      5              
  Lines          34     34              
========================================
+ Hits           31     34       +3     
+ Misses          3      0       -3
Impacted Files Coverage Δ
app/models/concerns/warclight/solr_document.rb 100% <0%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c9733...c190dbe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.