Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop-rspec to version 1.37.1 #100
Merged
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Dec 20, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
========================================
+ Coverage 91.17% 100% +8.82%
========================================
Files 5 5
Lines 34 34
========================================
+ Hits 31 34 +3
+ Misses 3 0 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
depfu bot commentedDec 20, 2019
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
1.37.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 14 commits:
Merge pull request #849 from rubocop-hq/release
Bump version to 1.37.1
Merge pull request #848 from schwern/docs/message-chain-cop
Merge pull request #846 from jfragoulis/factorybot/factoryclassname/exclude-ruby-builtins
Fix FactoryBot/FactoryClassName to ignore Hash and OpenStruct
Merge pull request #845 from ybiquitous/improve-message-and-description-of-FactoryBot/FactoryClassName
Improve message and description of `FactoryBot/FactoryClassName`
Generate the docs.
Fix "better" code in RSpec/MessageChain cop
Merge pull request #847 from jfragoulis/fix_master
Disable InternalAffairs/MethodNameEqual cop
Ignore offense with the right cop
Fix configuration error regarding hash alignment cop
Remove trailing space
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands