Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.79.0 #101

Merged
merged 1 commit into from Jan 7, 2020
Merged

Conversation

@depfu
Copy link
Contributor

depfu bot commented Jan 7, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.78.0 → ~> 0.79.0) · Repo · Changelog

Release Notes

0.79.0

New features

Bug fixes

  • #7193: Prevent Style/PercentLiteralDelimiters from changing %i literals that contain escaped delimiters. (@buehmann)
  • #7590: Fix an error for Layout/SpaceBeforeBlockBraces when using with EnforcedStyle: line_count_based of Style/BlockDelimiters cop. (@koic)
  • #7569: Make Style/YodaCondition accept __FILE__ == $0. (@koic)
  • #7576: Fix an error for Gemspec/OrderedDependencies when using a local variable in an argument of dependent gem. (@koic)
  • #7595: Make Style/NumericPredicate aware of ignored methods when specifying ignored methods. (@koic)
  • #7607: Fix Style/FrozenStringLiteralComment infinite loop when magic comments are newline-separated. (@pirj)
  • #7602: Ensure proper handling of Ruby 2.7 syntax. (@drenmi)
  • #7620: Fix a false positive for Migration/DepartmentName when a disable comment contains a plain comment. (@koic)
  • #7616: Fix an incorrect autocorrect for Style/MultilineWhenThen for when statement with then is an array or a hash. (@koic)
  • #7628: Fix an incorrect autocorrect for Layout/MultilineBlockLayout removing trailing comma with single argument. (@pawptart)
  • #7627: Fix a false negative for Migration/DepartmentName when there is space around : (e.g. # rubocop : disable). (@koic)

Changes

  • #7287: Style/FrozenStringLiteralComment is now considered unsafe. (@buehmann)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 49 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Jan 7, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #101   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a9eb9a...c45f7cf. Read the comment docs.

@ruebot ruebot merged commit 001ac4f into master Jan 7, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 2a9eb9a...c45f7cf
Details
codecov/project 100% remains the same compared to 2a9eb9a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rubocop-0.79.0 branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.