Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rspec-rails to version 4.0.0 #109

Merged
merged 1 commit into from Mar 26, 2020

Conversation

@depfu
Copy link
Contributor

depfu bot commented Mar 25, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rspec-rails (~> 3.0 → ~> 4.0) · Repo · Changelog

Release Notes

4.0.0 (from changelog)

Full Changelog

Enhancements:

  • Adds support for Rails 6. (Penelope Phippen, Benoit Tigeot, Jon Rowe, #2071)
  • Adds support for JRuby on Rails 5.2 and 6
  • Add support for parameterised mailers (Ignatius Reza, #2125)
  • Add ActionMailbox spec helpers and test type (James Dabbs, #2119)
  • Add ActionCable spec helpers and test type (Vladimir Dementyev, #2113)
  • Add support for partial args when using have_enqueued_mail (Ignatius Reza, #2118, #2125)
  • Add support for time arguments for have_enqueued_job (@alpaca-tc, #2157)
  • Improve path parsing in view specs render options. (John Hawthorn, #2115)
  • Add routing spec template as an option for generating controller specs. (David Revelo, #2134)
  • Add argument matcher support to have_enqueued_* matchers. (Phil Pirozhkov, #2206)
  • Switch generated templates to use ruby 1.9 hash keys. (Tanbir Hasan, #2224)
  • Add have_been_performed/have_performed_job/perform_job ActiveJob matchers (Isaac Seymour, #1785)
  • Default to generating request specs rather than controller specs when generating a controller (Luka Lüdicke, #2222)
  • Allow ActiveJob matchers #on_queue modifier to take symbolic queue names. (Nils Sommer, #2283)
  • The scaffold generator now generates request specs in preference to controller specs. (Luka Lüdicke, #2288)
  • Add configuration option to disable ActiveRecord. (Jon Rowe, Phil Pirozhkov, Hermann Mayer, #2266)
  • Set ActionDispatch::SystemTesting::Server.silence_puma = true when running system specs. (ta1kt0me, Benoit Tigeot, #2289)

Bug Fixes:

  • EmptyTemplateHandler.call now needs to support an additional argument in Rails 6. (Pavel Rosický, #2089)
  • Suppress warning from SQLite3Adapter.represent_boolean_as_integer which is deprecated. (Pavel Rosický, #2092)
  • ActionView::Template#formats has been deprecated and replaced by ActionView::Template#format(Seb Jacobs, #2100)
  • Replace before_teardown as well as after_teardown to ensure screenshots are generated correctly. (Jon Rowe, #2164)
  • ActionView::FixtureResolver#hash has been renamed to ActionView::FixtureResolver#data. (Penelope Phippen, #2076)
  • Prevent driven_by(:selenium) being called due to hook precedence. (Takumi Shotoku, #2188)
  • Prevent a WrongScopeError being thrown during loading fixtures on Rails 6.1 development version. (Edouard Chin, #2215)
  • Fix Mocha mocking support with should. (Phil Pirozhkov, #2256)
  • Restore previous conditional check for setting default_url_options in feature specs, prevents a NoMethodError in some scenarios. (Eugene Kenny, #2277)
  • Allow changing ActiveJob::Base.queue_adapter inside a system spec. (Jonathan Rochkind, #2242)
  • rails generate generator command now creates related spec file (Joel Azemar, #2217)
  • Relax upper capybara version constraint to allow for Capybara 3.x (Phil Pirozhkov, #2281)
  • Clear ActionMailer test mailbox after each example (Benoit Tigeot, #2293)

Breaking Changes:

  • Drops support for Rails below 5.0
  • Drops support for Ruby below 2.3

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Mar 25, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #109 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #109   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4e57b...e0108d4. Read the comment docs.

@ruebot ruebot merged commit 254228a into master Mar 26, 2020
2 checks passed
2 checks passed
codecov/patch Coverage not affected when comparing 3c4e57b...e0108d4
Details
codecov/project 100.00% (+0.00%) compared to 3c4e57b
Details
@depfu depfu bot deleted the depfu/update/rspec-rails-4.0.0 branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.