Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop-rspec to version 1.39.0 #117
Merged
Conversation
codecov
bot
commented
May 2, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 34 34
=========================================
Hits 34 34 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
depfu bot commentedMay 2, 2020
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
1.39.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 27 commits:
Merge pull request #906 from rubocop-hq/releaseBump version to v1.39.0Merge pull request #897 from tejasbubane/empty-hooks-copAdd new `RSpec/EmptyHook` copMerge pull request #903 from rubocop-hq/scattered-let-autocorrectImplement auto-correct for ScatteredLet copExtract helper class for moving nodes arroundMerge pull request #904 from tejasbubane/fix-771Fix multiple cops to detect `let` with proc argumentMerge pull request #899 from ngoral/replace_should_style_example_for_named_subjectReplace `should`-example with `expect`-exampleMerge pull request #900 from rubocop-hq/ci-matrixUse CircleCI matrix featureMerge pull request #901 from rubocop-hq/drop-support-for-ruby-2.3Drop support for Ruby 2.3Merge pull request #891 from AlexWayfer/disable_RSpec/DescribeClass_for_string_constantsIgnore String constants by `RSpec/Describe`Merge pull request #890 from koic/fix_offenses_using_rubocop_0_81Fix an offenses when using RuboCop 0.81.0Merge pull request #886 from aried3r/ar/add_capybara_visibility_copAdd Capybara/VisibilityMatcher copMerge pull request #869 from eitoball/use-relative-path-for-file_path-copMerge pull request #883 from yujideveloper/fix/old-cop-optionRemove already removed `AggregateFailuresByDefault` from default.ymlUse relative path to match with globMerge pull request #881 from rubocop-hq/fix-dstr-in-example-descriptionMerge pull request #878 from rubocop-hq/remove-oneDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands