Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.83.0 #119

Merged
merged 1 commit into from May 12, 2020
Merged

Conversation

@depfu
Copy link
Contributor

depfu bot commented May 12, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.82.0 → ~> 0.83.0) · Repo · Changelog

Release Notes

0.83.0

New features

  • #7951: Include rakefile file by default. (@jethrodaniel)
  • #7921: Add new Style/SlicingWithRange cop. (@zverok)
  • #7895: Include .simplecov file by default. (@robotdana)
  • #7916: Support autocorrection for Lint/AmbiguousRegexpLiteral. (@koic)
  • #7917: Support autocorrection for Lint/UselessAccessModifier. (@koic)
  • #595: Add ERB pre-processing for configuration files. (@jonas054)
  • #7918: Support autocorrection for Lint/AmbiguousOperator. (@koic)
  • #7937: Support autocorrection for Style/IfWithSemicolon. (@koic)
  • #3696: Add AllowComments option to Lint/EmptyWhen cop. (@koic)
  • #7910: Support autocorrection for Lint/ParenthesesAsGroupedExpression. (@koic)
  • #7925: Support autocorrection for Layout/ConditionPosition. (@koic)
  • #7934: Support autocorrection for Lint/EnsureReturn. (@koic)
  • #7922: Add new Layout/EmptyLineAroundAttributeAccessor cop. (@koic)

Bug fixes

  • #7929: Fix Style/FrozenStringLiteralComment to accept frozen_string_literal anywhere in leading comment lines. (@jeffcarbs)
  • #7882: Fix Style/CaseEquality when AllowOnConstant is true and the method receiver is implicit. (@rafaelfranca)
  • #7790: Fix --parallel and --ignore-parent-exclusion combination. (@jonas054)
  • #7881: Fix --parallel and --force-default-config combination. (@jonas054)
  • #7635: Fix a false positive for Style/MultilineWhenThen when then required for a body of when is used. (@koic)
  • #7905: Fix an error when running rubocop --only or rubocop --except options without cop name argument. (@koic)
  • #7903: Fix an incorrect autocorrect for Style/HashTransformKeys and Style/HashTransformValues cops when line break before to_h method. (@diogoosorio, @koic)
  • #7899: Fix an infinite loop error for Layout/SpaceAroundOperators with Layout/ExtraSpacing when using ForceEqualSignAlignment: true. (@koic)
  • #7885: Fix Style/IfUnlessModifier logic when tabs are used for indentation. (@jonas054)
  • #7909: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using an intended grouped parentheses. (@koic)
  • #7913: Fix a false positive for Lint/LiteralAsCondition when using true literal in while and similar cases. (@koic)
  • #7928: Fix a false message for Style/GuardClause when using and or or operators for guard clause in then or else branches. (@koic)
  • #7928: Fix a false positive for Style/GuardClause when assigning the result of a guard condition with else. (@koic)

Changes

  • #7860: Change AllowInHeredoc option of Layout/TrailingWhitespace to true by default. (@koic)
  • #7094: Clarify alignment in Layout/MultilineOperationIndentation. (@jonas054)
  • #4245: (Breaking) Inspect all files given on command line unless --only-recognized-file-types is given. (@jonas054)
  • #7390: (Breaking) Enabling a cop overrides disabling its department. (@jonas054)
  • #7936: Mark Lint/BooleanSymbol as unsafe. (@laurmurclar)
  • #7948: Mark unsafe for Style/OptionalArguments. (@koic)
  • #7931: Remove dependency on the jaro_winkler gem, instead depending on did_you_mean. This may be a breaking change for RuboCop libraries calling NameSimilarity#find_similar_name. (@bquorning)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 72 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label May 12, 2020
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1515b18...1e7cf84. Read the comment docs.

@ruebot ruebot merged commit 0650b92 into master May 12, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 1515b18...1e7cf84
Details
codecov/project 100.00% (+0.00%) compared to 1515b18
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rubocop-0.83.0 branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.