Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.78.0 #99

Merged
merged 1 commit into from Dec 20, 2019
Merged

Conversation

@depfu
Copy link
Contributor

depfu bot commented Dec 19, 2019

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.75.0 → ~> 0.78.0) · Repo · Changelog

Release Notes

0.78.0

New features

  • #7528: Add new Lint/NonDeterministicRequireOrder cop. (@mangara)
  • #7559: Add EnforcedStyleForExponentOperator parameter to Layout/SpaceAroundOperators cop. (@khiav223577)

Bug fixes

  • #7530: Typo in Style/TrivialAccessors's AllowedMethods. (@movermeyer)
  • #7532: Fix an error for Style/TrailingCommaInArguments when using an anonymous function with multiple line arguments with EnforcedStyleForMultiline: consistent_comma. (@koic)
  • #7534: Fix an incorrect autocorrect for Style/BlockDelimiters cop and Layout/SpaceBeforeBlockBraces cop with EnforcedStyle: no_space when using multiline braces. (@koic)
  • #7231: Fix the exit code to be 2 rather when 0 when the config file contains an unknown cop. (@jethroo)
  • #7513: Fix abrupt error on autocorrecting with --disable-uncorrectable. (@tejasbubane)
  • #7537: Fix a false positive for Layout/SpaceAroundOperators when using a Rational literal with / (e.g. 2/3r). (@koic)
  • #7029: Make Style/Attr not flag offense for custom attr method. (@tejasbubane)
  • #7574: Fix a corner case that made Style/GuardClause crash. (@buehmann)

Changes

  • #7514: Expose correctable status on offense and in formatters. (@tyler-ball)
  • #7542: (Breaking) Move LineLength cop from Metrics department to Layout department. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 32 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Dec 19, 2019
@ruebot

This comment has been minimized.

Copy link
Member

ruebot commented Dec 19, 2019

@​depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-0.78.0 branch from ac8ed34 to c0fd0be Dec 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #99   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de2db0...c0fd0be. Read the comment docs.

@ruebot ruebot merged commit d2c9733 into master Dec 20, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 6de2db0...c0fd0be
Details
codecov/project 100% remains the same compared to 6de2db0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rubocop-0.78.0 branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.