Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AR tracker: A Python package for detecting and tracking atmospheric rivers using image-processing #2197

Open
whedon opened this issue May 21, 2020 · 14 comments

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented May 21, 2020

Submitting author: @Xunius (Guangzhi XU)
Repository: https://github.com/ihesp/AR_tracker
Version: v1.0
Editor: @kbarnhart
Reviewer: Pending
Managing EiC: Kristen Thyng

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @Xunius. Currently, there isn't an JOSS editor assigned to your paper.

@Xunius if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label May 21, 2020
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 21, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@kthyng
Copy link

@kthyng kthyng commented May 21, 2020

Hi @Xunius! I have updated the repo address to https://github.com/ihesp/AR_tracker — let me know if this is incorrect.

@kthyng
Copy link

@kthyng kthyng commented May 21, 2020

@whedon check repository

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 21, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.17 s (229.6 files/s, 63563.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          16           1491           1837           3341
reStructuredText                14            520            174           1164
TeX                              1             48              0            587
Jupyter Notebook                 5              0           1260            339
Markdown                         2             62              0            194
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            40           2133           3279           5660
-------------------------------------------------------------------------------


Statistical information for the repository '2197' was gathered on 2020/05/21.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
guangzhi                        14          6835            166          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
guangzhi                   6669           97.6          0.0                8.68
@kthyng
Copy link

@kthyng kthyng commented May 21, 2020

@whedon generate pdf

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 21, 2020

PDF failed to compile for issue #2197 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/2197/joss/paper.md): found a tab character that violate intendation while scanning a plain scalar at line 9 column 11 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/lib/whedon.rb:125:in load_yaml'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/lib/whedon.rb:85:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@kthyng
Copy link

@kthyng kthyng commented May 21, 2020

@openjournals/dev Is there a reference for finding what characters are not allowed in the papers? It looks like that is the problem. Is & ok?

@kthyng
Copy link

@kthyng kthyng commented May 21, 2020

@Xunius I am conflicted on this paper so I will find another editor.

@kthyng
Copy link

@kthyng kthyng commented May 21, 2020

@kbarnhart I know I just asked you about another submission, but we plan not to assign over 3 total at the moment. Are you able to edit this submission too? I am a good fit but I am conflicted.

@kbarnhart
Copy link

@kbarnhart kbarnhart commented May 21, 2020

@kthyng I can handle this too.

@kbarnhart
Copy link

@kbarnhart kbarnhart commented May 21, 2020

@whedon assign @kbarnhart as editor

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 21, 2020

OK, the editor is @kbarnhart

@danielskatz
Copy link

@danielskatz danielskatz commented May 21, 2020

@openjournals/dev Is there a reference for finding what characters are not allowed in the papers? It looks like that is the problem. Is & ok?

This is not an issue with the paper body, but with the header.
Specifically, on line 10 of https://github.com/ihesp/AR_tracker/blob/master/joss/paper.md

	orcid: 0000-0001-5877-5608

should be

    orcid: 0000-0001-5877-5608

(basically, a tab needs to be replaced with 4 spaces)

@Xunius
Copy link

@Xunius Xunius commented May 21, 2020

Thanks. Just made a quick fix: ihesp/AR_tracker@6e617d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.