Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bridges to site tests and configuration docs #1784

Open
wants to merge 6 commits into
base: master
from

Conversation

@yadudoc
Copy link
Member

yadudoc commented Jun 26, 2020

Description

This PR adds support for site testing on Bridges and adds a tested configuration to the docs.

This also contains updates to conda_init documenting how to get conda env on bridges

Type of change

Please check the options below:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code maintentance/cleanup
  • Updates to existing or new tests
@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented on 8aa31ff Jun 20, 2020

Can you also add a bridges config to the docs?

yadudoc added 2 commits Jun 26, 2020
@yadudoc yadudoc requested review from danielskatz and ZhuozhaoLi Jun 26, 2020
@ZhuozhaoLi
Copy link
Contributor

ZhuozhaoLi commented Jun 26, 2020

there are some flake8 errors

yadudoc added 2 commits Jun 26, 2020
…ges_site_tests
label='Bridges_HTEX_multinode',
max_workers=1,
provider=SlurmProvider(
'YOUR_PARTITION_NAME', # Specify Partition / QOS, for eg. RM-small

This comment has been minimized.

Copy link
@danielskatz

danielskatz Jun 29, 2020

Collaborator

this shouldn't have "partition=" before it?

@danielskatz
Copy link
Collaborator

danielskatz commented Jun 29, 2020

channel=LocalChannel() is not needed in the provider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.