Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement typo fixes from @SamFritz, resolves #71 #86
+70
−94
Conversation
|
Thanks @ianmilligan1 for staging fixes! Just have two minor changes for binary sections: "audio files" should replace "images" in line 27 and "audio" to "audio files" for consistency |
| @@ -27,7 +27,7 @@ df.select($"url", $"filename", $"extension", $"mime_type_web_server", $"mime_typ | |||
|
|
|||
| Will extract all following information from images in a web collection: | |||
This comment has been minimized.
This comment has been minimized.
SamFritz
Jun 22, 2020
Member
sorry, I should have included line # to make things easier - "audio files" should replace "image" in line 27
docs/binary-analysis.md
Outdated
| @@ -26,7 +26,7 @@ df.select($"url", $"filename", $"extension", $"mime_type_web_server", $"mime_typ | |||
|
|
|||
| Will extract all following information from images in a web collection: | |||
This comment has been minimized.
This comment has been minimized.
SamFritz
Jun 22, 2020
Member
sorry, I should have included line # to make things easier - "audio files" should replace "image" in line 27
| @@ -89,15 +89,13 @@ df = archive.audio() | |||
| df.show() | |||
| ``` | |||
|
|
|||
| Will extract all following information from images in a web collection: | |||
| Will extract all following information from audio in a web collection: | |||
This comment has been minimized.
This comment has been minimized.
docs/binary-analysis.md
Outdated
| @@ -88,15 +88,13 @@ df = archive.audio() | |||
| df.show() | |||
| ``` | |||
|
|
|||
| Will extract all following information from images in a web collection: | |||
| Will extract all following information from audio in a web collection: | |||
This comment has been minimized.
This comment has been minimized.
|
Thanks @ianmilligan1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ianmilligan1 commentedJun 22, 2020
Implementing suggestions from #71 - thanks @SamFritz! As they apply to both these docs and the next, am applying to both version-0.80.0 and the docs directories.