New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create coverage reports; resolve #58. #65

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@ruebot
Member

ruebot commented Oct 4, 2018

Updated version of #59

@ruebot ruebot requested a review from greebie Oct 4, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 4, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@1d9c65b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage          ?   51.17%           
=========================================
  Files             ?        9           
  Lines             ?     1149           
  Branches          ?        0           
=========================================
  Hits              ?      588           
  Misses            ?      561           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9c65b...d133a97. Read the comment docs.

codecov bot commented Oct 4, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@1d9c65b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage          ?   51.17%           
=========================================
  Files             ?        9           
  Lines             ?     1149           
  Branches          ?        0           
=========================================
  Hits              ?      588           
  Misses            ?      561           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9c65b...d133a97. Read the comment docs.

@greebie

This comment has been minimized.

Show comment
Hide comment
@greebie

greebie Oct 4, 2018

Collaborator

"No coverage uploaded for pull request base" just means that there is no previous codecov report to form a comparison, correct? If so, this lgtm.

Collaborator

greebie commented Oct 4, 2018

"No coverage uploaded for pull request base" just means that there is no previous codecov report to form a comparison, correct? If so, this lgtm.

@greebie

greebie approved these changes Oct 4, 2018

lgtm.

@greebie greebie merged commit 96aded8 into archivesunleashed:master Oct 4, 2018

2 checks passed

codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruebot ruebot deleted the ruebot:issue-58-redux branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment