Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCommented out code in gexf.c #28
Comments
ruebot
added
the
question
label
Aug 27, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Aug 27, 2018
Collaborator
The commented out code is to support building into Igraph. Igraph requires graph level attributes (eg. "totalNodes") to accept a PR, but the Gexf (even the 1.3) does not support graph-level attributes.
Since the schema for gexf is not rigidly enforced, it can be uncommented or removed without causing too much trouble.
The potential benefit to auk is if you would like to include some summary information in a sigma graph. For example, if you wanted to have some network summary information included in the visualisation.
In reality, I do not think it is high priority. I will fork the repo from HEAD and keep the leftover code there.
|
The commented out code is to support building into Igraph. Igraph requires graph level attributes (eg. "totalNodes") to accept a PR, but the Gexf (even the 1.3) does not support graph-level attributes. Since the schema for gexf is not rigidly enforced, it can be uncommented or removed without causing too much trouble. The potential benefit to auk is if you would like to include some summary information in a sigma graph. For example, if you wanted to have some network summary information included in the visualisation. In reality, I do not think it is high priority. I will fork the repo from HEAD and keep the leftover code there. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ruebot
Aug 27, 2018
Member
Sounds like it should be in a feature branch, and worked on there. Once it is ready, it can be pulled in the master.
|
Sounds like it should be in a feature branch, and worked on there. Once it is ready, it can be pulled in the master. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
That sounds like a good idea. I'll set one up. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ruebot
Aug 28, 2018
Member
New branch here: https://github.com/archivesunleashed/graphpass/tree/issue-34
|
New branch here: https://github.com/archivesunleashed/graphpass/tree/issue-34 |
ruebot commentedAug 27, 2018
There are a couple chunks of commented out code in
src/gexf.c. Are they required, or can they be removed?