Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate coverage reports; resolve #58. #59
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov
bot
Sep 5, 2018
Codecov Report
❗️ No coverage uploaded for pull request base (master@b1f8eec). Click here to learn what that means.
The diff coverage isn/a.
@@ Coverage Diff @@
## master #59 +/- ##
=========================================
Coverage ? 50.13%
=========================================
Files ? 9
Lines ? 1099
Branches ? 0
=========================================
Hits ? 551
Misses ? 548
Partials ? 0Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update b1f8eec...b8c4462. Read the comment docs.
codecov
bot
commented
Sep 5, 2018
•
edited
Edited 4 times
-
codecov bot
edited Sep 6, 2018 (most recent)
-
codecov bot
edited Sep 6, 2018
-
codecov bot
edited Sep 5, 2018
-
codecov bot
edited Sep 5, 2018
-
codecov bot
created Sep 5, 2018
edited
-
Sep 6, 2018 (most recent) -
Sep 6, 2018 -
Sep 5, 2018 -
Sep 5, 2018 -
Sep 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=========================================
Coverage ? 50.13%
=========================================
Files ? 9
Lines ? 1099
Branches ? 0
=========================================
Hits ? 551
Misses ? 548
Partials ? 0Continue to review full report at Codecov.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ruebot
Sep 5, 2018
Member
Hey! There we go.
So, we need to decide if we're ok with all the files that are generated in the root when make is run. The extensions are added to .gitignore.
Before:
[nruest@wombat:graphpass] (git)-[issue-58]-$ ls
CODE_OF_CONDUCT.md CONTRIBUTING.md doc Doxyfile LICENSE.txt Makefile README.md src vendor
After:
[nruest@wombat:graphpass] (git)-[issue-58]-$ ls
analyze.gcda CODE_OF_CONDUCT.md doc filter.gcda gexf.gcda graphpass graphpass.gcno io.gcno Makefile quickrun.gcda README.md reports.gcno rnd.gcno vendor viz.gcno
analyze.gcno CONTRIBUTING.md Doxyfile filter.gcno gexf.gcno graphpass.gcda io.gcda LICENSE.txt OUT quickrun.gcno reports.gcda rnd.gcda src viz.gcda
|
Hey! There we go. So, we need to decide if we're ok with all the files that are generated in the root when Before: After: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Sep 5, 2018
Collaborator
This is amazing! Thank you so much. If codecov uses gcov, I think its possible to put the gcdas in a different folder using -fprofile-dir {DIRECTORY}. Not sure if that can work for codecov though.
(reference:here)
greebie
commented
Sep 5, 2018
•
edited
Edited 2 times
-
greebie
edited Sep 5, 2018 (most recent)
-
greebie
edited Sep 5, 2018
-
greebie
created Sep 5, 2018
edited
-
Sep 5, 2018 (most recent) -
Sep 5, 2018 -
Sep 5, 2018
|
This is amazing! Thank you so much. If codecov uses gcov, I think its possible to put the gcdas in a different folder using -fprofile-dir {DIRECTORY}. Not sure if that can work for codecov though. (reference:here) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
We'd still have the |
ruebot
and others
added some commits
Sep 5, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Sep 6, 2018
Collaborator
Just added the extra files for removal using make clean.
Not sure if cleaning helps with codecov, but at least someone can run it if they do not like the extra files.
|
Just added the extra files for removal using Not sure if cleaning helps with codecov, but at least someone can run it if they do not like the extra files. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Sep 6, 2018
Collaborator
Do we need to merge this to see the proper reports? Did you want a merge to check? Based on what I see so far, we should be okay to do that. Neither Ian nor I care too much about the extra files and now that we have a clean, it should be fine.
|
Do we need to merge this to see the proper reports? Did you want a merge to check? Based on what I see so far, we should be okay to do that. Neither Ian nor I care too much about the extra files and now that we have a clean, it should be fine. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Please don't push to a pull request I'm working on. |
ruebot commentedSep 5, 2018
GitHub issue(s): #58
What does this Pull Request do?
How should this be tested?
TravisCI should pass, and CodeCov should be triggered.
Additional Notes:
I'm not 100% happy with all the files that are generated in the root. I'd like to make this better, but first I want to see if this works with CodeCov.