Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove graph attributes from gexf output (not supported by networkx). #68 #69
Conversation
This comment has been minimized.
This comment has been minimized.
|
@ruebot I think @ianmilligan1 is fine to review this. I just wanted to flag this as something that has some upstream issues. I do not think it's urgent, because we are pointing people to gephi and not networkx for graph analysis. But notice the bash command if you want to just fix all the gexfs. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Feb 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 51.17% 51.94% +0.76%
==========================================
Files 9 9
Lines 1149 1132 -17
==========================================
Hits 588 588
+ Misses 561 544 -17
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
Cool. Thanks for providing a backwards fix. That's super helpful Once this is merged, feel free to tag a release, or if you want me to, I can do it. I'll throw it on the production instance when it's good to go. |
ianmilligan1
approved these changes
Feb 21, 2019
|
Tested and the ensuing file both works on Gephi and in @greebie's |
ruebot
merged commit ddbb38a
into
master
Feb 22, 2019
ruebot
deleted the
issue-68
branch
Feb 22, 2019
This comment has been minimized.
This comment has been minimized.
|
Deployed to production, and updated existing files: Should be good to go with this example: |
This comment has been minimized.
This comment has been minimized.
|
|
greebie commentedFeb 21, 2019
GitHub issue(s):
#68
What does this Pull Request do?
Removes the graph attributes from the gexf output.
Graph attributes are analyses about the entire graph (e.g. average density)
and are not supported in gexf.
How should this be tested?
The best way to test this is to:
- Output
./graphpass -qg {CollectionId}-gephi.graphmlon an existing graphml from auk to{CollectionId}-gephi.gexf- Add file to
datafolder to an AUK-NOTEBOOKS instance.- Change
coll_idto {CollectionId}- Run the first two windows + the last (network analysis) window. It should produce a graph.
Additional Notes:
The following perl command will fix the problem with existing gexf files. This is a better option than try to redo files upstream.
perl -0777 -i.original -pe 's/\s+<attributes class="graph">\s+<\/attributes>//' {CollectionId}-gephi.gexf(I tried to use sed, but multi-line find and replace got more complicated than I wanted it to be.)
Interested parties
@ianmilligan1 @ruebot
Thanks in advance for your help with the Archives Unleashed Project!