Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop-rspec to version 1.38.0 #104

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@depfu
Copy link
Contributor

depfu bot commented Feb 12, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (~> 1.37.1 → ~> 1.38.0) · Repo · Changelog

Release Notes

1.38.0

  • Fix RSpec/InstanceVariable detection inside custom matchers. (@pirj)
  • Fix RSpec/ScatteredSetup to distinguish hooks with different metadata. (@pirj)
  • Add autocorrect support for RSpec/ExpectActual cop. (@dduugg, @pirj)
  • Add RSpec/RepeatedExampleGroupBody cop. (@lazycoder9)
  • Add RSpec/RepeatedExampleGroupDescription cop. (@lazycoder9)
  • Add block name and other lines to RSpec/ScatteredSetup message. (@elebow)
  • Fix RSpec/RepeatedDescription to take into account example metadata. (@lazycoder9)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 25 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Feb 12, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #104 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #104   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ec91a...b43365d. Read the comment docs.

@ruebot ruebot merged commit 05ca990 into master Feb 12, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 07ec91a...b43365d
Details
codecov/project 100.00% (+0.00%) compared to 07ec91a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.38.0 branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.