Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguation by add year suffix was not present - Added it to the s… #4200

Merged
merged 1 commit into from Aug 22, 2019
+1 −1

Conversation

@lorenzino
Copy link
Contributor

commented Jul 16, 2019

…tyle

It was:

Now is:

disambiguate-add-year-suffix="true"
@lorenzino
Disambiguation by add year suffix was not present - Added it to the s… 
…tyle

It was:
 <citation et-al-min="3" et-al-use-first="1" disambiguate-add-names="true" disambiguate-add-givenname="true" givenname-disambiguation-rule="primary-name">

Now is:  
<citation et-al-min="3" et-al-use-first="1" disambiguate-add-names="true" disambiguate-add-givenname="true" givenname-disambiguation-rule="primary-name" disambiguate-add-year-suffix="true">
disambiguate-add-year-suffix="true"
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c659b82
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 16, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 16, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

international-journal-of-spatial-data-infrastructures-research.csl (modified style; unchanged output for sample items)
(, 2007; , 2012)
(Mares; , 2001; Fenner et al.; , 2019)
(2007). Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York: Oxford University Press.
(2012). CSL search by example, at http://editor.citationstyles.org/searchByExample/, [accessed 15 December 2012].
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019). A data citation roadmap for scholarly data repositories, Scientific Data, 6(1), at http://www.nature.com/articles/s41597-019-0031-8, [accessed 27 April 2019].
Mares, I. (2001). "Firms and the welfare state: When, why, and how does social policy matter to employers?", in Hall, P. A. and D. Soskice (Eds.). Varieties of capitalism. The institutional foundations of comparative advantage, New York: Oxford University Press, pp.. 184–213.

@lorenzino lorenzino closed this Jul 23, 2019

@lorenzino lorenzino reopened this Jul 23, 2019

@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 23, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

international-journal-of-spatial-data-infrastructures-research.csl (modified style; unchanged output for sample items)
(, 2007; , 2012)
(Mares; , 2001; Fenner et al.; , 2019)
(2007). Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York: Oxford University Press.
(2012). CSL search by example, at http://editor.citationstyles.org/searchByExample/, [accessed 15 December 2012].
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019). A data citation roadmap for scholarly data repositories, Scientific Data, 6(1), at http://www.nature.com/articles/s41597-019-0031-8, [accessed 27 April 2019].
Mares, I. (2001). "Firms and the welfare state: When, why, and how does social policy matter to employers?", in Hall, P. A. and D. Soskice (Eds.). Varieties of capitalism. The institutional foundations of comparative advantage, New York: Oxford University Press, pp.. 184–213.
@stale

This comment has been minimized.

Sign in to view
Copy link

commented Aug 22, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Aug 22, 2019

@adam3smith adam3smith merged commit a806a01 into citation-style-language:master Aug 22, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 22, 2019

Thanks! Sorry this took so long.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting
Projects
None yet
Milestone
No milestone
3 participants
@lorenzino @csl-bot @adam3smith
You can’t perform that action at this time.