Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace '&' with '&' when exporting to HTML or XML #249
+25
−9
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 4, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 82.81% 82.91% +0.09%
==========================================
Files 18 18
Lines 902 907 +5
==========================================
+ Hits 747 752 +5
Misses 155 155
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
This is the minor TravisCI patch I promised earlier. |
This comment has been minimized.
This comment has been minimized.
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bokov commentedDec 4, 2019
•
edited
Except column headers for XML where '&' and ' ' both get replaced by '.'. Fixes #234
Please ensure the following before submitting a PR:
/Rnot/manand rundevtools::document()to update documentation not applicable/testsfor any new functionality or bug fixR CMD checkruns without error before submitting the PRTravisCI builds for this project still are failing (#246 and #242) and so this one will fail too. The simplest and fastest way to address that is to simply remove
xcode8.3from.travis.yml, so a more current default xcode version will be used for osx tests. Also, the manual install ofllvmon osx is no longer required, the problem is fixed at the CRAN level (until the next R version bump?). Now it just contributes to CI failures by taking too long. In other words, the changes proposed in #247 (without the minor tweaks).After I submit this PR, I will submit an additional commit on this branch that makes the above two changes so you could see that the tests do pass. I apologize for deviating from normal "one issue per PR" process.