Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove messages when tests are skipped due to missing packages #212
+63
−53
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jun 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 18 18
Lines 880 880
=======================================
Hits 717 717
Misses 163 163Continue to review full report at Codecov.
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jun 27, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 18 18
Lines 880 880
=======================================
Hits 717 717
Misses 163 163Continue to review full report at Codecov.
|
leeper
merged commit bb83cb6
into
leeper:master
Sep 9, 2019
billdenney
deleted the
billdenney:test-skip-notification
branch
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
billdenney commentedJun 27, 2019
While working on #211, I got several errors about libraries missing. I updated the tests so that the missing libraries are now indicated as skipped tests across the board rather than having them show up as errors in some cases. Also, skipped libraries were sometimes not shown since they were inside
if (requireNamespace())calls where it seems like it is preferable to show that the test is skipped rather than not showing the test at all.