Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/rio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I got Mac builds to stop failing on Travis-CI by... #247

Merged
merged 1 commit into from Dec 17, 2019
Merged

I got Mac builds to stop failing on Travis-CI by... #247

merged 1 commit into from Dec 17, 2019
+1 −8

Conversation

@bokov
Copy link
Contributor

bokov commented Nov 8, 2019

  1. removing the xcode8.3 setting, letting the current default (and newer) version of xcode be used instead.
  2. taking the before_install script back out because now the data.table binary is again available.

Fixes #246. Fixes #242

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR
@bokov
I got Mac builds to stop failing on Travis-CI by 1) removing the xcod…
Loading status checks…
5ccaa2b 
…e8.3 setting, letting the current default (and newer) version of xcode be used instead. Also took the before_install script back out because now the data.table binary is again available. Fixes #246. Fixes #242
@bokov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bokov commented Nov 8, 2019

Also, removed sudo, renamed matrix to jobs in accordance with Travis-CI's warnings/suggestions.

https://travis-ci.org/bokov/rio/jobs/609046329/config
@bokov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bokov commented Nov 13, 2019

The Appveyor tests are no longer failing for this PR:

https://ci.appveyor.com/project/bokov/rio/builds/28837111

The upstream problem causing #244 is fixed by CRAN updating their directory structure.

If you rebuild your version this PR will no longer be failing.
@bokov bokov mentioned this pull request Nov 14, 2019
Open
1 of 3 tasks complete
bokov added a commit to bokov/rio that referenced this pull request Nov 14, 2019
@bokov
.travis.yml; ci; Possible non-broken xcode8.3 version, post results on …
Loading status checks…
9a43e0e 
…leeper#247 comment when/if successful
@bokov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bokov commented Nov 14, 2019 •
edited

If the reason for this PR not being accepted is that xcode8.3 is a requirement, I now have an alternate .travis.yml for xcode8.3. It's slower than this one, but avoids timeouts by splitting MacOS into two separate stages. It can be seen here: https://travis-ci.org/bokov/rio/builds/612038019

The other changes are: llvm homebrew install commented out (data.table binaries up to date on CRAN again), removed deprecated setting sudo, and renamed matrix to jobs as per current Travis CI format.

Please let me know if you would like me to submit that one as a PR and retract this one.
@bokov bokov mentioned this pull request Dec 4, 2019
Merged
5 of 6 tasks complete
bokov added a commit to bokov/rio that referenced this pull request Dec 4, 2019
@bokov
Added minimum .travis.yml changes to avoid MacOS build failure on Tra…
Loading status checks…
62f5cf8 
…visCI (see leeper#246, leeper#242, leeper#247)
leeper added a commit that referenced this pull request Dec 17, 2019
@bokov @leeper
Added minimum .travis.yml changes to avoid MacOS build failure on Tra…
Loading status checks…
2991a10 
…visCI (see #246, #242, #247)
@leeper leeper merged commit 38d19a6 into leeper:master Dec 17, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leeper

This comment has been minimized.

Sign in to view
Copy link
Owner

leeper commented Dec 17, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bokov @leeper
You can’t perform that action at this time.