Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… #4871

Merged
merged 3 commits into from Jun 23, 2020

Conversation

@anfourny
Copy link
Contributor

anfourny commented Jun 16, 2020

…al-et-europeen.csl

These changes were made by a student after he received feedback from a group who used this style. He then submitted this updated version of the style to me. It's been so long since I worked on this code, I'd be very grateful if someone could help me and see if everything seems OK.

Thanks!

…al-et-europeen.csl

These changes were made by a student after he received feedback from a group who used this style. He then submitted this updated version of the style to me. It's been so long since I worked on this code, I'd be very happy if someone could help me and see if everything seems OK.
@anfourny

This comment has been minimized.

Pretty sure the suffix should be ", " with an extra space

@csl-bot
Copy link

csl-bot commented Jun 16, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Jun 16, 2020

😟 There are some issues with your submission.

2 tests failed

uclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to return true, got false

uclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen: may not have any unused macros

expected: []
     got: ["locatorX"]

(compared using ==)

Please check the test report for details.

…al-et-europeen.csl
@csl-bot
Copy link

csl-bot commented Jun 17, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

uclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen.csl (modified style; unchanged output for sample items)
 ; .
 ; .

« CSL search by example », Citation Style Editor, 2012, disponible sur http://editor.citationstyles.org/searchByExample/ (consulté le 15 décembre 2012).
Fenner, M. et al., « A data citation roadmap for scholarly data repositories », Scientific Data, 2019, volume 6, 1, p. 28, disponible sur http://www.nature.com/articles/s41597-019-0031-8 (consulté le 27 avril 2019).
Hancké, B., Rhodes, M. et Thatcher, M. (éd.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, vol., Oxford and New York, Oxford University Press, 2007.
Mares, I., « Firms and the welfare state: When, why, and how does social policy matter to employers? », in P.A. Hall et D. Soskice (éd.) Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001p. 184‑213.
@csl-bot
Copy link

csl-bot commented Jun 20, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

uclouvain-centre-charles-de-visscher-pour-le-droit-international-et-europeen.csl (modified style; unchanged output for sample items)
 ; .
 ; .

« CSL search by example », Citation Style Editor, 2012, disponible sur http://editor.citationstyles.org/searchByExample/ (consulté le 15 décembre 2012).
Fenner, M. et al., « A data citation roadmap for scholarly data repositories », Scientific Data, 2019, volume 6, 1, p. 28, disponible sur http://www.nature.com/articles/s41597-019-0031-8 (consulté le 27 avril 2019).
Hancké, B., Rhodes, M. et Thatcher, M. (éd.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, vol., Oxford and New York, Oxford University Press, 2007.
Mares, I., « Firms and the welfare state: When, why, and how does social policy matter to employers? », in P.A. Hall et D. Soskice (éd.) Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001p. 184‑213.
@rmzelle
Copy link
Member

rmzelle commented Jun 21, 2020

@adam3smith, LGTM.

@adam3smith adam3smith merged commit 7e0828d into citation-style-language:master Jun 23, 2020
@adam3smith
Copy link
Member

adam3smith commented Jun 23, 2020

Thanks! (I changed the code for bill/legislation to what I assume was intended: testing match="all" on more than one type will always return false, so that didn't make sense as written)

@anfourny
Copy link
Contributor Author

anfourny commented Jun 23, 2020

Thank you guys so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.