Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manchester #4878

Open
wants to merge 9 commits into
base: master
from

Conversation

@icornelius
Copy link
Contributor

icornelius commented Jun 20, 2020

rename manchester-university-press.csl to distinguish author-date and note-bib variants of this citation style.
Rebuild the note-bib style from a new template to improve accuracy of the output.
Create the author-date style using note-bib as template.

@csl-bot
Copy link

csl-bot commented Jun 20, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Jun 20, 2020

😟 There are some issues with your submission.

4 tests failed

past-and-present: "template" link must point to an existing independent style

expected ["associacao-brasileira-de-normas-tecnicas-ufmg-face-full", "new-phytologist", "traces", "internation..."medecine-sciences", "historical-social-research", "springer-fachzeitschriften-medizin-psychologie"] to include "manchester-university-press"

manchester-university-press-author-date: "template" link must point to an existing independent style

expected ["associacao-brasileira-de-normas-tecnicas-ufmg-face-full", "new-phytologist", "traces", "internation..."medecine-sciences", "historical-social-research", "springer-fachzeitschriften-medizin-psychologie"] to include "manchester-university-press"

manchester-university-press-author-date: may not have any unused macros

expected: []
     got: ["contributors-note", "locators-note", "point-locators-subsequent", "title-short"]

(compared using ==)

manchester-university-press-note-bibliography: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/manchester-university-press-note-bibliography"
     got: "http://www.zotero.org/styles/manchester-university-press"

(compared using ==)

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Jun 20, 2020

😟 There are some issues with your submission.

2 tests failed

past-and-present: "template" link must point to an existing independent style

expected ["associacao-brasileira-de-normas-tecnicas-ufmg-face-full", "new-phytologist", "traces", "internation..."medecine-sciences", "historical-social-research", "springer-fachzeitschriften-medizin-psychologie"] to include "manchester-university-press"

manchester-university-press-note-bibliography: "self" link must match the style ID

expected: "http://www.zotero.org/styles/manchester-university-press"
     got: "http://www.zotero.org/styles/manchester-university-press-note-bibliography"

(compared using ==)

Please check the test report for details.

@csl-bot
Copy link

csl-bot commented Jun 20, 2020

😟 There are some issues with your submission.

1 test failed

past-and-present: "template" link must point to an existing independent style

expected ["associacao-brasileira-de-normas-tecnicas-ufmg-face-full", "new-phytologist", "traces", "internation..."medecine-sciences", "historical-social-research", "springer-fachzeitschriften-medizin-psychologie"] to include "manchester-university-press"

Please check the test report for details.

@icornelius
Copy link
Contributor Author

icornelius commented Jun 20, 2020

The file that I update and rename is referenced as template by another csl file in the repo. (The name-change removes ambiguity between note-and-bibliography and author-date variants of Manchester University Press style.) I'm not sure what to do about the error. Help, please?

Perhaps I should have retained the existing file name, despite ambiguity.

(this isn't about the template -- which we could adjust -- but rather about that fact that we're increasingly trying to avoid id changes to avoid issues in upstream implementations like Zotero, Mendeley, et al.
@csl-bot
Copy link

csl-bot commented Jun 20, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

manchester-university-press-author-date.csl (new)
(Hancké, Rhodes, and Thatcher, 2007; ‘CSL Search by Example’, 2012)
(Mares, 2001; Fenner et al., 2019)

‘CSL search by example’ (2012), Citation Style Editor, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012]
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, et al. (2019), ‘A data citation roadmap for scholarly data repositories’, Scientific Data, 6:1, 28, https://doi.org/10.1038/s41597-019-0031-8
Hancké, Bob, Martin Rhodes, and Mark Thatcher (eds) (2007), Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press)
Mares, Isabela (2001), ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in Peter A. Hall and David Soskice (eds), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (New York: Oxford University Press), pp. 184–213
manchester-university-press.csl (modified style)
Bob Hancké, Martin Rhodes, and Mark Thatcher (eds), Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); ‘CSL search by example’, Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012].
Isabela Mares, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in Peter A. Hall and David Soskice (eds), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (New York: Oxford University Press, 2001), pp. 184–213; Martin Fenner et al., ‘A data citation roadmap for scholarly data repositories’, Scientific Data, 6:1 (2019), 28, https://doi.org/10.1038/s41597-019-0031-8.

‘CSL search by example’, Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012]
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, et al., ‘A data citation roadmap for scholarly data repositories’, Scientific Data, 6:1 (2019), 28, https://doi.org/10.1038/s41597-019-0031-8
Hancké, Bob, Martin Rhodes, and Mark Thatcher (eds), Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007)
Mares, Isabela, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in Peter A. Hall and David Soskice (eds), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (New York: Oxford University Press, 2001), pp. 184–213
-Bob Hancké, Martin Rhodes, and Mark Thatcher (eds.), <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i> (Oxford and New York, 2007); ‘CSL search by example’, <i>Citation Style Editor</i>, (2012).<br/>
-Isabela Mares, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in Peter A. Hall and David Soskice (eds.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, (New York, 2001), pp. 184–213; Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone, and Tim Clark, ‘A data citation roadmap for scholarly data repositories’, <i>Sci. Data</i>, 6:1 (April 2019), p. 28.<br/>
+Bob Hancké, Martin Rhodes, and Mark Thatcher (eds), <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); ‘CSL search by example’, <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012].<br/>
+Isabela Mares, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in Peter A. Hall and David Soskice (eds), <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> (New York: Oxford University Press, 2001), pp. 184–213; Martin Fenner et al., ‘A data citation roadmap for scholarly data repositories’, <i>Scientific Data</i>, 6:1 (2019), 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+<hr/>
+‘CSL search by example’, <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012]<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, et al., ‘A data citation roadmap for scholarly data repositories’, <i>Scientific Data</i>, 6:1 (2019), 28, https://doi.org/10.1038/s41597-019-0031-8<br/>
+Hancké, Bob, Martin Rhodes, and Mark Thatcher (eds), <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007)<br/>
+Mares, Isabela, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in Peter A. Hall and David Soskice (eds), <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> (New York: Oxford University Press, 2001), pp. 184–213<br/>
@adam3smith
Copy link
Member

adam3smith commented Jun 20, 2020

This looks good. I am seeing initials, not full names, for authors in the style guide though -- any reason you're using full names?

@icornelius
Copy link
Contributor Author

icornelius commented Jun 20, 2020

I wondered about that. The style guide gives initials, as you note, but does not stipulate usage. The single reference I find is in section 5.4.2 (first bullet point), stating that in the bibliography "surname should precede first name or initials". I have checked three MUP books published in 2020: two use author forenames, one initials. I suppose we could ask an editor at MUP. Let me see if I can get a response.

@icornelius
Copy link
Contributor Author

icornelius commented Jun 20, 2020

Confirming that the style should initialize given names.

@csl-bot
Copy link

csl-bot commented Jun 20, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

manchester-university-press-author-date.csl (new)
(Hancké, Rhodes, and Thatcher, 2007; ‘CSL Search by Example’, 2012)
(Mares, 2001; Fenner et al., 2019)

‘CSL search by example’ (2012), Citation Style Editor, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012]
Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, et al. (2019), ‘A data citation roadmap for scholarly data repositories’, Scientific Data, 6:1, 28, https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., M. Rhodes, and M. Thatcher (eds) (2007), Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press)
Mares, I. (2001), ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in P. A. Hall and D. Soskice (eds), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (New York: Oxford University Press), pp. 184–213
manchester-university-press.csl (modified style)
B. Hancké, M. Rhodes, and M. Thatcher (eds), Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); ‘CSL search by example’, Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012].
I. Mares, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in P. A. Hall and D. Soskice (eds), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (New York: Oxford University Press, 2001), pp. 184–213; M. Fenner et al., ‘A data citation roadmap for scholarly data repositories’, Scientific Data, 6:1 (2019), 28, https://doi.org/10.1038/s41597-019-0031-8.

‘CSL search by example’, Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012]
Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, et al., ‘A data citation roadmap for scholarly data repositories’, Scientific Data, 6:1 (2019), 28, https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., M. Rhodes, and M. Thatcher (eds), Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007)
Mares, I., ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in P. A. Hall and D. Soskice (eds), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (New York: Oxford University Press, 2001), pp. 184–213
-Bob Hancké, Martin Rhodes, and Mark Thatcher (eds.), <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i> (Oxford and New York, 2007); ‘CSL search by example’, <i>Citation Style Editor</i>, (2012).<br/>
-Isabela Mares, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in Peter A. Hall and David Soskice (eds.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, (New York, 2001), pp. 184–213; Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone, and Tim Clark, ‘A data citation roadmap for scholarly data repositories’, <i>Sci. Data</i>, 6:1 (April 2019), p. 28.<br/>
+B. Hancké, M. Rhodes, and M. Thatcher (eds), <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); ‘CSL search by example’, <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012].<br/>
+I. Mares, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in P. A. Hall and D. Soskice (eds), <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> (New York: Oxford University Press, 2001), pp. 184–213; M. Fenner et al., ‘A data citation roadmap for scholarly data repositories’, <i>Scientific Data</i>, 6:1 (2019), 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+<hr/>
+‘CSL search by example’, <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012]<br/>
+Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, et al., ‘A data citation roadmap for scholarly data repositories’, <i>Scientific Data</i>, 6:1 (2019), 28, https://doi.org/10.1038/s41597-019-0031-8<br/>
+Hancké, B., M. Rhodes, and M. Thatcher (eds), <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007)<br/>
+Mares, I., ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in P. A. Hall and D. Soskice (eds), <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> (New York: Oxford University Press, 2001), pp. 184–213<br/>
@adam3smith
Copy link
Member

adam3smith commented Jun 20, 2020

@rmzelle good to go from my end, but want to make sure you're OK with the IDs & titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.