Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTesting and additional fixes #12
+448
−42
Conversation
shawnmjones
added some commits
Jul 10, 2019
shawnmjones
self-assigned this
Jul 11, 2019
shawnmjones
merged commit 79b3561
into
master
Jul 11, 2019
shawnmjones
deleted the
docker-fixes
branch
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
shawnmjones commentedJul 11, 2019
The branch is misnamed. It turned out there was no problem with the Docker setup. I added automated testing and found some additional items to update along the way.