Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: HPX - The C++ Standard Library for Parallelism and Concurrency #2352
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @bhatele, @davidbeckingsale it looks like you're currently assigned to review this paper Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #2352 with the following error: Can't find any papers to compile :-( |
@whedon generate pdf from branch JOSS |
|
@whedon check references from branch JOSS |
|
|
If you see small problems that need to be discussed, feel free to discuss them here. But if you can, create a new issue in the [target repository]](https://github.com/STEllAR-GROUP/hpx) and link to this review thread in that issue to create a corresponding breadcrumb trail here. I look forward to seeing how this review goes |
You can rerun the commands above to ask whedon to regenerate the pdf and check the references again as needed. |
@diehlpk - can you offer a quick bit of rationale behind author selection? A couple of contributors are not on the author list, but have more contributions (in terms of commits/loc) than some of the other authors. |
@davidbeckingsale We sent some an email and one reminder to our mailing lists and invited people to contribute to the paper before the deadline. The current list of authors followed the invitation and contributed to the paper. However, we could not contact over 100 contributors in person. |
Perfect. Sorry for being pedantic, I am just trying to make sure that the rationale for each of the checklist points is document somewhere |
@whedon check references from branch JOSS |
|
|
@whedon generate pdf from branch JOSS |
|
Attempting to check references... from custom branch JOSS |
@whedon generate pdf from branch JOSS |
|
@whedon check references from branch JOSS |
|
|
@danielskatz We fixed all issues with the DOI reported by whedon. |
@whedon generate pdf from branch JOSS |
|
@diehlpk - I don't feel that the paper addresses the following review point: "State of the field: Do the authors describe how this software compares to other commonly-used packages?" Could you please add a brief overview of related work and compare hpx to these other packages? |
|
|
We're working on them. Thanks. |
@whedon check references from branch JOSS |
|
|
@whedon generate pdf from branch JOSS |
|
We highlighted the review paper
which is a very nice overview of AMTS. In addition, we added a paragraph to the paper and highlighted that the main features of HPX is the distributed computing capability with some other notable AMTS. Among this, the future-proof C++ standard conforming API is the major difference. I am sorry for the delay, but I had two important deadlines this week. |
|
@danielskatz - my checklist shows the tasks I have completed. I had some other priorities last week but will make more review progress this week. |
|
whedon commentedJun 17, 2020
•
edited by davidbeckingsale
Submitting author: @diehlpk (Patrick Diehl)
Repository: https://github.com/STEllAR-GROUP/hpx
Version: 1.4.1
Editor: @danielskatz
Reviewer: @bhatele, @davidbeckingsale
Archive: Pending
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@bhatele & @davidbeckingsale, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
Review checklist for @bhatele
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @davidbeckingsale
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper