Skip to content

/ styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing cs:sort to cs:bibliography in universitat-bern-institut-fur-musikwissenschaft #4860

Merged
merged 1 commit into from Jun 20, 2020
Merged

add missing cs:sort to cs:bibliography in universitat-bern-institut-fur-musikwissenschaft #4860

merged 1 commit into from Jun 20, 2020

Conversation

@denismaier
Copy link
Member

denismaier commented Jun 12, 2020 •
edited

@adam3smith This fixes the erroneous sorting reported at https://forums.zotero.org/discussion/comment/357476

I'm not sure if just using <key macro="author_title-bibliography"/> is a wise choice, or if using the content of that macro would have any benefits:

<sort>
  <key macro="primary-contributor"/>
  <key macro="title_volumes"/>
</sort>
@denismaier
add missing cs:sort to cs:bibliography
dbe29f3
@csl-bot
Copy link

csl-bot commented Jun 12, 2020

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot
Copy link

csl-bot commented Jun 12, 2020

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

universitat-bern-institut-fur-musikwissenschaft-note.csl (modified style)
; .
; .
CSL search by example geführt von, 2012, <http://editor.citationstyles.org/searchByExample/> [15.12.2012].
Fenner, Martin / Crosas, Mercè / Grethe, Jeffrey S. / Kennedy, David / Hermjakob, Henning / Rocca-Serra, Phillippe / Durand, Gustavo / Berjon, Robin / Karcher, Sebastian / Martone, Maryann / Clark, Tim: „A data citation roadmap for scholarly data repositories“ geführt von, in: Scientific Data 6 (2019), H. 1, S. 28, <https://doi.org/10.1038/s41597-019-0031-8> [27.4.2019].
Hancké, Bob / Rhodes, Martin / Thatcher, Mark (Hrsg.): Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy geführt von, Oxford and New York: Oxford University Press 2007.
Mares, Isabela: „Firms and the welfare state: When, why, and how does social policy matter to employers?“ geführt von, in: Varieties of capitalism. The institutional foundations of comparative advantage, hrsg. v. Peter A. Hall u. David Soskice, New York: Oxford University Press 2001, S. 184–213.
 ; .<br/>
 ; .<br/>
 <hr/>
-Hancké, Bob / Rhodes, Martin / Thatcher, Mark (Hrsg.): <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i> geführt von, Oxford and New York: Oxford University Press 2007.<br/>
 <i>CSL search by example</i> geführt von, 2012, &lt;http://editor.citationstyles.org/searchByExample/&gt; [15.12.2012].<br/>
-Mares, Isabela: „Firms and the welfare state: When, why, and how does social policy matter to employers?“ geführt von, in: <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, hrsg. v. Peter A. Hall u. David Soskice, New York: Oxford University Press 2001, S. 184–213.<br/>
 Fenner, Martin / Crosas, Mercè / Grethe, Jeffrey S. / Kennedy, David / Hermjakob, Henning / Rocca-Serra, Phillippe / Durand, Gustavo / Berjon, Robin / Karcher, Sebastian / Martone, Maryann / Clark, Tim: „A data citation roadmap for scholarly data repositories“ geführt von, in: <i>Scientific Data</i> 6 (2019), H. 1, S. 28, &lt;https://doi.org/10.1038/s41597-019-0031-8&gt; [27.4.2019].<br/>
+Hancké, Bob / Rhodes, Martin / Thatcher, Mark (Hrsg.): <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i> geführt von, Oxford and New York: Oxford University Press 2007.<br/>
+Mares, Isabela: „Firms and the welfare state: When, why, and how does social policy matter to employers?“ geführt von, in: <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, hrsg. v. Peter A. Hall u. David Soskice, New York: Oxford University Press 2001, S. 184–213.<br/>
@denismaier denismaier changed the title add missing cs:sort to cs:bibliography add missing cs:sort to cs:bibliography in universitat-bern-institut-fur-musikwissenschaft Jun 12, 2020
@adam3smith
Copy link
Member

adam3smith commented Jun 20, 2020

Thanks! I don't think using the whole macro versus its parts makes a difference, no.
@adam3smith adam3smith merged commit d5661ba into citation-style-language:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@denismaier @csl-bot @adam3smith
You can’t perform that action at this time.