Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSTOR - https + copyright #2093

Open
wants to merge 6 commits into
base: master
from
Open

JSTOR - https + copyright #2093

wants to merge 6 commits into from
+82 −72

Conversation

@placardo
Copy link
Contributor

placardo commented Dec 20, 2019

See #2088
@placardo
https + copyright
Loading status checks…
c5ba489
@placardo placardo changed the title https + copyright JSOTR - https + copyright Dec 20, 2019
@placardo placardo changed the title JSOTR - https + copyright JSTOR - https + copyright Dec 20, 2019
@dstillman
dstillman reviewed Dec 20, 2019
View changes
JSTOR.js Outdated Show resolved Hide resolved
placardo added 3 commits Dec 20, 2019
@placardo
linting
Loading status checks…
924c439
@placardo
linting
Loading status checks…
ac02da6
@placardo
deleted unused function
Loading status checks…
e65d7e7
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Dec 21, 2019

This lgtm -- could you squash the last three commits into one?
placardo added 2 commits Dec 20, 2019
@placardo
linting
81f3f38 
linting

deleted unused function

linting
@placardo
Merge branch 'jstor' of https://github.com/placardo/translators into …
Loading status checks…
bdf8f79 
…jstor

linting
@placardo

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

placardo commented Dec 21, 2019

Well apparently that did not work - in the interest of time saving could you tell me how to squash my commits? I thought you did this on your end when you merged
@dstillman

This comment has been minimized.

Sign in to view
Copy link
Member

dstillman commented Dec 21, 2019

I'll squash this appropriately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam3smith adam3smith

@dstillman dstillman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@placardo @adam3smith @dstillman
You can’t perform that action at this time.