Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title in Mainichi Daily News.js + linting issues #2091

Merged
merged 2 commits into from Dec 17, 2019

Conversation

@adam3smith adam3smith merged commit 1839dee into zotero:master Dec 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Dec 17, 2019

Thanks! (not sure if you got my initial [now deleted] comment about text() -- the text() definition was hidden in the linting commit, which confused me.)

@zuphilip zuphilip deleted the zuphilip:mainchi-update-2019 branch Dec 17, 2019
@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Dec 17, 2019

No, I haven't seen your comment, but it may be in my email inbox ;-)

Sorry, I first thought that the text is not needed because we simply need it for the doc but linting showed my then differently and extraction of multiples were strange otherwise, because then all items received the title of the search website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.