Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/ styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical align fix #2256

Merged
merged 6 commits into from Oct 1, 2016
Merged

Vertical align fix #2256

merged 6 commits into from Oct 1, 2016

Conversation

@adam3smith
Copy link
Member

adam3smith commented Oct 1, 2016

using
perl -0777 -i -p -e 's/(layout.*)(>\n\s*)<text variable=\"citation-number\" vertical-align=\"sup\"/$1 vertical-align=\"sup\"$2<text variable=\"citation-number\"/' ./*.csl
then manually correcting for the too permissive regex.
(and no, I don't really know how to perl...)
adam3smith added 4 commits Oct 1, 2016
@adam3smith
Correct vertical-align
dd27c42 
using `perl -0777 -i -p -e 's/(layout.*)(>\n\s*)<text
variable=\"citation-number\" vertical-align=\"sup\"/$1 vertical-align=\"sup\"$2<text variable=\"citation-number\"/' ./*.csl`
(and no, I don't really know how to perl...)
@adam3smith
Rever cases in bibliography
6aac720
@adam3smith
properly revert
e26f612
@adam3smith
one more revert
Loading status checks…
2f7b8a4
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Oct 1, 2016

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Oct 1, 2016

😟 There are some issues with your submission. Please check the test report for details.
@adam3smith
remove duplicate vertical-align
Loading status checks…
c30676d
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Oct 1, 2016

😃 Your submission passed all our automated tests.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member Author

adam3smith commented Oct 1, 2016

@rmzelle -- I think this is ready, but leaving for you to merge for 2nd set of eyes.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Oct 1, 2016 •
edited

You'd probably want to revert

american-institute-of-aeronautics-and-astronautics.csl
american-institute-of-physics.csl
international-journal-of-sports-medicine.csl
pediatric-anesthesia.csl
revista-virtual-de-quimica.csl

(all have changes in the bibliography)
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Oct 1, 2016 •
edited

And with my own jEdit find-regex of ^.*variable="citation-number".*vertical-align="sup"(.*\n)*.*</citation> I found 47 styles with vertical-align="sup" following variable="citation-number". in the citation section (https://forums.zotero.org/discussion/comment/262999/#Comment_262999). There don't seem to be any cases of elements with vertical-align="sup" preceding variable="citation-number".
@adam3smith
Five more reverts
Loading status checks…
98396e4 
@rmzelle -- down to 47 now, should be all correct now
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Oct 1, 2016

😃 Your submission passed all our automated tests.
@rmzelle rmzelle merged commit 69cd543 into citation-style-language:master Oct 1, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Oct 1, 2016

Thanks :)
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Oct 1, 2016

(I'm surprised we didn't get more complaints about this, by the way, seeing how common this pattern was)
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member Author

adam3smith commented Oct 1, 2016

I think these were mostly 2nd tier Elsevier journals (the mistake was introduced by one of their folks who checked styles), so not exactly our most popular styles, but yes, I would have thought we'd get a few more reports, too.
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Oct 1, 2016

I added a note in the QC wiki: https://github.com/citation-style-language/styles/wiki/Quality-Control/_compare/4d1191512d82508703987471ccb7c132a0f506e6...96ee92a5546cc17570922f99299a72aa6d6d38db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adam3smith @csl-bot @rmzelle
You can’t perform that action at this time.