New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hainan-medical-university-journal-publisher.csl #2576

Merged

rmzelle merged 5 commits into citation-style-language:master from unknown repository

Mar 23, 2017

Contributor

POBrien333 commented Mar 19, 2017

as discussed here: https://forums.zotero.org/discussion/comment/272314/#Comment_272314
I would make this the main style and the dependents come from this style.
I'll revert #2570 back to a dependent style then.


        Create asian-pacific-journal-of-tropical-medicine.csl

462635a

as discussed here: https://forums.zotero.org/discussion/comment/272314/#Comment_272314
I would make this the main style and the dependents come from this style.
I'll revert #2570 back to a dependent style then.

csl-bot commented Mar 19, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

csl-bot commented Mar 19, 2017

😃 Your submission passed all our automated tests.

adam3smith requested changes

Member

adam3smith left a comment •

edited by rmzelle

Some small comments. Two general observations:
I'd as much as possible include delimiters between elements in the bibliography (ideally as group delimiters), not in the macros. That makes the styles a lot easier to understand and to modify (otherwise you always have to guess where a delimiter happens to be placed).
Also, I recommend putting spaces into only one sort of affix -- either prefix or suffix. Otherwise, if you miss something and have, e.g. a prefix=". " hit a suffix=". ', you get . . which citeproc doesn't fix.

asian-pacific-journal-of-tropical-medicine.csl Outdated

  
          <macro name="editor">

            <names variable="editor" suffix=". ">

              <name sort-separator=" " initialize-with="" name-as-sort-order="all" delimiter=", " delimiter-precedes-last="always" delimiter-precedes-et-al="never"/>

              <label strip-periods="true" prefix=", "/>

adam3smith Mar 19, 2017

Member

Don't strip the period here -- it's OK if it duplicates with the period from the suffix, since citeproc will switch it (and it's part of the abbreviation)

asian-pacific-journal-of-tropical-medicine.csl Outdated

  
                <text variable="publisher"/>

                <text variable="publisher-place"/>

              </group>

              <group>

adam3smith Mar 19, 2017

Member

no need for this group

asian-pacific-journal-of-tropical-medicine.csl Outdated

  
                <text variable="container-title" form="short" font-style="italic" strip-periods="true"/>

              </if>

              <else>

                <text variable="container-title" suffix=". " form="short"/>

adam3smith Mar 19, 2017

Member

abbreviating book titles is usually a bad idea. I'd remove the form="short"

asian-pacific-journal-of-tropical-medicine.csl Outdated

  
            </names>

          </macro>

          <macro name="editor">

            <names variable="editor" suffix=". ">

adam3smith Mar 19, 2017

Member

I find this much easier to read if you don't set the affix in the macro but instead only as delimiters in the bibliography

asian-pacific-journal-of-tropical-medicine.csl Outdated

  
                  </group>

                </if>

                <else-if type="chapter paper-conference" match="any">

                  <group prefix=" " suffix=". ">

adam3smith Mar 19, 2017

Member

no need for the space in the suffix (it's in the prefix below)

asian-pacific-journal-of-tropical-medicine.csl Outdated

  
                  </group>

                  <group delimiter=": " prefix=" ">

                    <text macro="publisher"/>

                    <group delimiter=" ">

adam3smith Mar 19, 2017

Member

no need for the group.

asian-pacific-journal-of-tropical-medicine.csl Outdated

  
              <if variable="page" match="none">

                <choose>

                  <if variable="DOI">

                    <text variable="DOI" prefix=" doi:"/>

adam3smith Mar 19, 2017

Member

don't put the space in the prefix here -- you don't have it for the URL, either. Instead, include a prefix=" " for the macro in the bibliography

POBrien333 added 2 commits


        Update asian-pacific-journal-of-tropical-medicine.csl

59ae353

Most helpful. Thanks Adam. I usually do 80% of the work with the visual editor, but I do understand that is also why I bring in some mistakes. I'll be more diligent and use the mentioned "rules" to write better code. :)


        Update asian-pacific-journal-of-tropical-medicine.csl

7243f3d

csl-bot commented Mar 20, 2017

😃 Your submission passed all our automated tests.

1 similar comment

csl-bot commented Mar 20, 2017

😃 Your submission passed all our automated tests.


        Update and rename asian-pacific-journal-of-tropical-medicine.csl to h…

f3cdf30

…ainan-medical-university-journal-publisher.csl

csl-bot commented Mar 22, 2017

😟 There are some issues with your submission. Please check the test report for details.


        Update hainan-medical-university-journal-publisher.csl

960b2ef

("generic base" should be "generic-base")

csl-bot commented Mar 23, 2017

😃 Your submission passed all our automated tests.

rmzelle merged commit 99b04b6 into citation-style-language:master

1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

Details

Member

rmzelle commented Mar 23, 2017

Thanks!

POBrien333 changed the title ~~Create asian-pacific-journal-of-tropical-medicine.csl~~ Create hainan-medical-university-journal-publisher.csl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.