Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create european-journal-of-endocrinology.csl #2389

Merged
merged 3 commits into from Jan 1, 2017

Conversation

@sylverestoermann
Copy link
Contributor

sylverestoermann commented Dec 29, 2016

Style for European Journal of Endocrinology, based on Vancouver style
Documentation (http://www.eje-online.org/site/misc/For-Authors.xhtml) is sparse and includes only three example references (2x article-journal, 1x chapter). Other details were derived from the bibliography of actual and recent publications in the journal.

Style for European Journal of Endocrinology, based on Vancouver style
Documentation (http://www.eje-online.org/site/misc/For-Authors.xhtml) is sparse and includes only three example references (2x article-journal, 1x chapter). Other details were derived from the bibliography of actual and recent publications in the journal.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 29, 2016

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@sylverestoermann

This comment has been minimized.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2016

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 30, 2016

😃 Your submission passed all our automated tests.

<name-part name="given" text-case="uppercase"/>
</name>
</names>
</group>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Dec 30, 2016

Member

@adam3smith, do you know what we usually do in these cases? http://www.eje-online.org/site/misc/For-Authors.xhtml#refs indeed shows "Eds J-C Job & M Pierson", but http://docs.citationstyles.org/en/stable/specification.html#label-in-cs-names says

The optional cs:label element (see label) must be included after the cs:name and cs:et-al elements, but before the cs:substitute element.

So we can't put the label before <name/>. That seems like an oversight, and I couldn't find a ticket to allow it.

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 1, 2017

Member

that must be a typo in the specs and we don't validate this, so it's OK to allow imo. Otherwise we're in trouble:
We have cs:label before cs:name all over the place, e.g. for pretty much any verb form of the label, see e.g. https://github.com/citation-style-language/styles/blob/master/chicago-fullnote-bibliography.csl#L56

This comment has been minimized.

Copy link
@rmzelle
<macro name="edition">
<choose>
<if is-numeric="edition">
<number prefix="edn " variable="edition" suffix=", "/>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Dec 30, 2016

Member

@sylverestoermann, thanks. I already simplified the style a little by removing some superfluous <group/> elements (they don't add anything if they only have a single child element).

Otherwise, if you're up for it, the main thing you could improve is to rely less on verbatim text labels like prefix="edn " above, and instead use CSL terms, which make styles easier to reuse in other languages, and which can automatically adapt to whether the variable contains a singular or plural value.

E.g. here, you could change <number prefix="edn " variable="edition" suffix=", "/> to

        <group delimiter=" " suffix=", ">
          <text term="edition" form="short"/> 
          <number variable="edition"/>
        </group>

(in this case, because the standard translation for the "short" form of the "edition" in British English is "ed" [see https://github.com/citation-style-language/locales/blob/master/locales-en-GB.xml#L34 ], you'd have to redefine this term as well by adding a locale section after the info section, e.g.

  <locale xml:lang="en">
    <terms>
      <term name="edition" form="short">edn</term>
    </terms>
  </locale>

)

If that's too complicated we can accept the style like this as well.

This comment has been minimized.

Copy link
@sylverestoermann

sylverestoermann Jan 1, 2017

Author Contributor

Thank you for the revisions, I highly appreciate it.

I understand how technically it would be cleaner to use CSL terms, but I have a full-time job as physician, a business on the side and a loving wife and children. So time is sparse and I have to carefully select what to use it for. The journal has not dramatically changed its citation style in the past few years (cf. for example author guidelines in the Wayback Machine) and there likely won't be major changes in the future (especially regarding the abbreviations used). It is also unlikely that localization will be an issue unless maybe the whole scientific community decides to change its lingua franca (which would not happen overnight anyways). So, in essence, the benefit of achieving perfection in technical terms (no change in output) does not warrant the cost (I'm not that adept at CSL that I could do this quickly).

This comment has been minimized.

Copy link
@rmzelle

rmzelle Jan 1, 2017

Member

Sure, no problem!

(just to clarify: were not concerned with this journal changing its publishing language, but with being able to reuse (parts of) this CSL style for publications in other languages, which is easier if the style doesn't use hard-coded English text. But it's not that big of a deal here, so don't worry about it.)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 1, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit bbf99b0 into citation-style-language:master Jan 1, 2017
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 1, 2017

@sylverestoermann, thanks for contributing!

@sylverestoermann

This comment has been minimized.

Copy link
Contributor Author

sylverestoermann commented Jan 2, 2017

You're welcome. Thanks for your help!

@sylverestoermann sylverestoermann deleted the sylverestoermann:patch-1 branch Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.