Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hainan-medical-university-journal-publisher.csl #2576

Merged
merged 5 commits into from Mar 23, 2017

Conversation

@POBrien333
Copy link
Contributor

POBrien333 commented Mar 19, 2017

as discussed here: https://forums.zotero.org/discussion/comment/272314/#Comment_272314
I would make this the main style and the dependents come from this style.
I'll revert #2570 back to a dependent style then.

as discussed here: https://forums.zotero.org/discussion/comment/272314/#Comment_272314
I would make this the main style and the dependents come from this style.
I'll revert #2570 back to a dependent style then.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 19, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 19, 2017

😃 Your submission passed all our automated tests.

Copy link
Member

adam3smith left a comment

Some small comments. Two general observations:
I'd as much as possible include delimiters between elements in the bibliography (ideally as group delimiters), not in the macros. That makes the styles a lot easier to understand and to modify (otherwise you always have to guess where a delimiter happens to be placed).
Also, I recommend putting spaces into only one sort of affix -- either prefix or suffix. Otherwise, if you miss something and have, e.g. a prefix=". " hit a suffix=". ', you get . . which citeproc doesn't fix.

<macro name="editor">
<names variable="editor" suffix=". ">
<name sort-separator=" " initialize-with="" name-as-sort-order="all" delimiter=", " delimiter-precedes-last="always" delimiter-precedes-et-al="never"/>
<label strip-periods="true" prefix=", "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 19, 2017

Member

Don't strip the period here -- it's OK if it duplicates with the period from the suffix, since citeproc will switch it (and it's part of the abbreviation)

<text variable="publisher"/>
<text variable="publisher-place"/>
</group>
<group>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 19, 2017

Member

no need for this group

<text variable="container-title" form="short" font-style="italic" strip-periods="true"/>
</if>
<else>
<text variable="container-title" suffix=". " form="short"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 19, 2017

Member

abbreviating book titles is usually a bad idea. I'd remove the form="short"

</names>
</macro>
<macro name="editor">
<names variable="editor" suffix=". ">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 19, 2017

Member

I find this much easier to read if you don't set the affix in the macro but instead only as delimiters in the bibliography

</group>
</if>
<else-if type="chapter paper-conference" match="any">
<group prefix=" " suffix=". ">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 19, 2017

Member

no need for the space in the suffix (it's in the prefix below)

</group>
<group delimiter=": " prefix=" ">
<text macro="publisher"/>
<group delimiter=" ">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 19, 2017

Member

no need for the group.

<if variable="page" match="none">
<choose>
<if variable="DOI">
<text variable="DOI" prefix=" doi:"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 19, 2017

Member

don't put the space in the prefix here -- you don't have it for the URL, either. Instead, include a prefix=" " for the macro in the bibliography

POBrien333 added 2 commits Mar 20, 2017
Most helpful. Thanks Adam. I usually do 80% of the work with the visual editor, but I do understand that is also why I bring in some mistakes. I'll be more diligent and use the mentioned "rules" to write better code. :)
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 20, 2017

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 20, 2017

😃 Your submission passed all our automated tests.

…ainan-medical-university-journal-publisher.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 22, 2017

😟 There are some issues with your submission. Please check the test report for details.

("generic base" should be "generic-base")
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 23, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 99b04b6 into citation-style-language:master Mar 23, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Mar 23, 2017

Thanks!

@POBrien333 POBrien333 changed the title Create asian-pacific-journal-of-tropical-medicine.csl Create hainan-medical-university-journal-publisher.csl Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.