Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update american-journal-of-medical-genetics.csl #2702

Merged
merged 3 commits into from May 30, 2017

Conversation

@jxchong
Copy link
Contributor

jxchong commented May 23, 2017

Per instructions to authors downloaded today "References are cited in text with brackets, not parentheses."

Per instructions to authors downloaded today "References are cited in text with brackets, not parentheses."
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 23, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 23, 2017

😃 Your submission passed all our automated tests.

Remove commas from between author first initial and last name. Instructions to authors gives these examples:

```
For Journals: Bellini C, Donarini G, Palandini D, Calovo MG, Bellini T, Ramenghi LA, Hennekam RC. 2015. Etiology of N-immune Hydrops Fetalis: An Update. Am J Med Genet Part A 167A: 1082-1088.
Books:Cassidy SB, Allanson JE, editors. 2010. Management of Genetic Syndromes, Third Edition, Hoboken, NJ: John Wiley and Sons.
Chapter in Book:Battaglia A. 2010. Wolf-Hirschhorn syndrome. In: Cassidy SB, Allanson JE, editors, Management of Genetic Syndromes, Third Edition, Hoboken, NJ: John Wiley and Sons, pp 249-262.
```
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 23, 2017

😃 Your submission passed all our automated tests.

@@ -24,13 +24,13 @@
</info>
<macro name="editor">
<names variable="editor" delimiter=", ">
<name name-as-sort-order="all" sort-separator=", " initialize-with="" delimiter=", " delimiter-precedes-last="always"/>
<name name-as-sort-order="all" sort-separator=", " initialize-with="" delimiter=" " delimiter-precedes-last="always"/>

This comment has been minimized.

Copy link
@rmzelle

rmzelle May 30, 2017

Member

@jxchong, this isn't quite right. The "delimiter" attribute on <name/> affects the delimiter between subsequent names. To change the delimiter between "Lastname Initials", you have to change the "sort-separator" attribute value.

That said, which instructions are you looking at, exactly? At http://onlinelibrary.wiley.com/journal/10.1002/%28ISSN%291552-4833/homepage/ForAuthors.html (the "documentation" link of this style, for American Journal of Medical Genetics Part A), different examples are given:

For Journals: Thomas, G. H. (1996). High male:female ratio of germ-line mutations: An alternative explanation for postulated gestational lethality in males in X-linked dominant disorders. American Journal of Human Genetics, 58, 1364–1368.

Books:Cassidy SB, Allanson JE, editors. 2010. Management of Genetic Syndromes, Third Edition, Hoboken, NJ: John Wiley and Sons.

Chapter in Book:Battaglia A. 2010. Wolf-Hirschhorn syndrome. In: Cassidy SB, Allanson JE, editors, Management of Genetic Syndromes, Third Edition, Hoboken, NJ: John Wiley and Sons, pp 249-262.

and a recent article from the journal, http://onlinelibrary.wiley.com/doi/10.1002/ajmg.a.38220/pdf, uses comma-space in names, at least for journal articles: "Tluczek, A., Orland, K. M., & Cavanagh, L". The same article also uses parentheses around in-text citations, instead of brackets.

This comment has been minimized.

Copy link
@jxchong

jxchong May 30, 2017

Author Contributor

Yes that's the correct documentation link/instructions for authors, you have to go to the "References" section to see the mention of brackets instead of parentheses.

The reason this was brought to my attention is because we have a paper currently in review and the editor requested we fix our reference and in-text citation styles to match with the Instructions to Authors and said "please note Wiley has recently changed these." So I'm assuming that recent journal articles are lagging behind and still using the old style since we've been given explicit instructions to change the styling from what is in place now.

This comment has been minimized.

Copy link
@jxchong

jxchong May 30, 2017

Author Contributor

Fixed the delimited and sort-separator attributes.

Here's what that link says in the "References" section:

_____ References are cited in text with brackets, not parentheses.
_____ References in bibliography are alphabetized, without numbering.
_____ Every author is specified.
_____ Authors’ name punctuation is limited to commas between authors.
_____ Page numbers include beginning and ending page number (e.g., do not use the 1083-9 convention).
restored delimiter and removed comma from sort-separator
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 30, 2017

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented May 30, 2017

(I'm a little confused why git isn't more unhappy given 4ff49a4 -- sorry about that -- but I'm otherwise fine with this; @rmzelle please merge when you're hapy)

@rmzelle rmzelle merged commit b30d526 into citation-style-language:master May 30, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented May 30, 2017

@jxchong, okay, thanks for clarifying and submitting this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.