Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create journal-of-economic-and-social-geography.csl #2812

Merged
merged 11 commits into from Jul 16, 2017

Conversation

@POBrien333
Copy link
Contributor

POBrien333 commented Jul 14, 2017

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 14, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 14, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 14, 2017

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jul 14, 2017

I see both in catalogs, but I think I'd be inclined to go with the Dutch rather than the English title of the journal here. (as the main title and id, that is)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 14, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 14, 2017

😟 There are some issues with your submission. Please check the test report for details.

…r-economische-en-sociale-geografie.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 14, 2017

😟 There are some issues with your submission. Please check the test report for details.

…hrift-voor-economische-en-sociale-geografie.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 14, 2017

😃 Your submission passed all our automated tests.

<date-part name="day" suffix=", "/>
<date-part name="year"/>
</date>
</locale>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Jul 15, 2017

Member

@POBrien333, this locale section has a different ("en-US") locale than the style itself ("en-GB"), so it won't be used. Can you check if it's not necessary, and if so, remove it?

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 15, 2017

Member

it's not used, the style uses en-GB data formats. I'll remove it.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 15, 2017

😃 Your submission passed all our automated tests.

</names>
</macro>
<macro name="author-short">
<names variable="author" prefix="(">

This comment has been minimized.

Copy link
@rmzelle

rmzelle Jul 15, 2017

Member

@POBrien333, I see that it's part of the template style, but could you fix these unbalanced parentheses? In practically all cases the opening and closing parentheses should be on the same element.

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jul 15, 2017

Member

(sorry, I'll let you finish review; thought you were done)

This comment has been minimized.

Copy link
@rmzelle

rmzelle Jul 15, 2017

Member

I'm done otherwise. (if we fix the parentheses issue, we should check if we can quickly fix arachnology too, since this is pretty bad)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 15, 2017

😃 Your submission passed all our automated tests.

fix in-text citation parentheses. thanks for pointing it out.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 15, 2017

😃 Your submission passed all our automated tests.

<group delimiter=" " suffix=")">
<label suffix=")" variable="locator" form="short"/>
<text variable="locator" suffix=")"/>
</group>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Jul 15, 2017

Member

@POBrien333, did you see these three suffix=")" as well?

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 15, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 16, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jul 16, 2017

(updated arachnology.csl in this PR as well with similar parentheses fixes)

@rmzelle rmzelle merged commit c41a672 into citation-style-language:master Jul 16, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jul 16, 2017

Thanks!

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Jul 16, 2017

Awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.