Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate haematologica.csl & medicinal-research-reviews.csl #2832
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
found a tiny mistake.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
|
|
A couple of nits. Thanks! |
| <macro name="author"> | ||
| <names variable="author" suffix=". "> | ||
| <name sort-separator=" " initialize-with="" name-as-sort-order="all" delimiter=", " delimiter-precedes-last="always"/> | ||
| <label form="short" prefix=" (" suffix=")" strip-periods="true"/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jul 20, 2017
Member
unless there's a specific example, I'd expect the editor format to be the same as for book chapters, i.e. , editor(s)
| <text variable="publisher" suffix=";"/> | ||
| </group> | ||
| <choose> | ||
| <if variable="URL" match="none"> |
This comment has been minimized.
This comment has been minimized.
| <macro name="title"> | ||
| <choose> | ||
| <if type="book patent report thesis" match="any"> | ||
| <text variable="title"/> |
This comment has been minimized.
This comment has been minimized.
| <text macro="edition"/> | ||
| <text macro="publisher"/> | ||
| <group> | ||
| <text variable="number-of-pages" prefix=" "/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jul 20, 2017
Member
remove the prefix -- the space is already in the delimiter on line 159
| </group> | ||
| <text macro="publisher"/> | ||
| </group> | ||
| <label variable="page" form="short" prefix=" "/> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
|
also overworked this style (the template style). Found a few samples for chapters thankfully, as it's not in their guidelines.
POBrien333
changed the title
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 20, 2017
|
|
adam3smith
merged commit b0a3604
into
citation-style-language:master
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
POBrien333 commentedJul 20, 2017
•
edited by rmzelle
via https://forums.zotero.org/discussion/66610/update-citation-style-for-haematologica