Create comparative-politics.csl #2840

POBrien333 · 2017-07-25T16:27:37Z

via https://forums.zotero.org/discussion/55343/style-request-comparative-politics

Open article here: http://www.ingentaconnect.com/contentone/cuny/cp/2014/00000047/00000001/art00007

Can you guys help me with the ibid stuff?


        Create comparative-politics.csl

via https://forums.zotero.org/discussion/55343/style-request-comparative-politics Open article here: http://www.ingentaconnect.com/contentone/cuny/cp/2014/00000047/00000001/art00007 Can you guys help me with the ibid stuff?

csl-bot · 2017-07-25T16:27:44Z

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

csl-bot · 2017-07-25T16:33:16Z

😃 Your submission passed all our automated tests.

rmzelle · 2017-07-26T03:11:56Z

Can you guys help me with the ibid stuff?

What specifically do you need help with? The Chicago styles are good examples of how you would usually test for "position" (since cites can have more than one value for "position", you generally test from most specific, i.e. "ibid-with-locator", to least specific, i.e. "subsequent"). See http://docs.citationstyles.org/en/stable/specification.html#choose and e.g.

styles/chicago-fullnote-bibliography.csl

Line 1249 in 9e5c5b0


        Update comparative-politics.csl

POBrien333 · 2017-07-26T10:03:13Z

Thanks, @rmzelle
Each individual citation should have their own number though. Currently it gives me the same number if it was already cited. How can I get it to do that?

csl-bot · 2017-07-26T10:06:13Z

😟 There are some issues with your submission. Please check the test report for details.


        Update comparative-politics.csl

csl-bot · 2017-07-26T11:05:18Z

😃 Your submission passed all our automated tests.

adam3smith · 2017-07-26T11:09:58Z

you have this as a numeric in-text style. It should be a "note" style like the Chicago note and full note styles, which will also take care of the numbering issue.

POBrien333 · 2017-07-26T12:45:48Z

dang. I was wondering about that. :((


        Update comparative-politics.csl

POBrien333 · 2017-07-27T14:10:36Z

@adam3smith
I've just replaced the citation section with the whole bibliography section. That should work, right?

csl-bot · 2017-07-27T14:15:42Z

😟 There are some issues with your submission. Please check the test report for details.


        Update comparative-politics.csl

csl-bot · 2017-07-27T14:24:32Z

😃 Your submission passed all our automated tests.


        Update comparative-politics.csl

rmzelle · 2017-07-28T03:53:33Z

@adam3smith, metadata looks good to me. Can you merge after reviewing the code?

csl-bot · 2017-07-28T03:56:13Z

😃 Your submission passed all our automated tests.

adam3smith

A couple of small nits left. @rmzelle please go ahead and merge once these are fixed, will likely be a week until I'd get to it.

adam3smith · 2017-07-30T12:53:06Z

comparative-politics.csl

+  </macro>
+  <macro name="editor">
+    <names variable="editor">
+      <name and="text" delimiter-precedes-last="never" initialize-with="."/>


I'm seeing Stanley Rosen and Peter Hays Gries, eds. in the instructions, i.e. without initialize-with

adam3smith · 2017-07-30T12:53:06Z

comparative-politics.csl

+          <text term="in" suffix=" "/>
+          <group delimiter=", ">
+            <text macro="editor"/>
+            <text variable="container-title" form="short" text-case="title" font-style="italic"/>


Pretty sure that the form="short" shouldn't be here.

adam3smith · 2017-07-30T12:53:06Z

comparative-politics.csl

+            <text variable="container-title" form="short" text-case="title" font-style="italic"/>
+            <text macro="edition"/>
+          </group>
+          <group delimiter=", " prefix=" ">


no need for the prefix -- you have that in the publisher macro already.

adam3smith · 2017-07-30T12:53:06Z

comparative-politics.csl

+            <text variable="container-title" text-case="title" font-style="italic"/>
+            <group delimiter=" ">
+              <text variable="volume" font-weight="normal"/>
+              <text macro="year-date" prefix="(" suffix=")"/>


instructions suggest this should be month and year? (January 2013)


        Update comparative-politics.csl

Thanks for spotting those issues.


        Update comparative-politics.csl

csl-bot · 2017-07-30T15:53:32Z

😃 Your submission passed all our automated tests.

csl-bot · 2017-07-30T15:55:58Z

😃 Your submission passed all our automated tests.

rmzelle · 2017-07-30T18:34:00Z

Thanks!

Create comparative-politics.csl

Loading status checks…

b12ed7f

via https://forums.zotero.org/discussion/55343/style-request-comparative-politics Open article here: http://www.ingentaconnect.com/contentone/cuny/cp/2014/00000047/00000001/art00007 Can you guys help me with the ibid stuff?

POBrien333 changed the title ~~Create comparative-politics.csl~~ Create comparative-politics.csl (help with ibid needed) Jul 25, 2017

Update comparative-politics.csl

Loading status checks…

eb6d80f

Update comparative-politics.csl

Loading status checks…

e18ca2d

POBrien333 changed the title ~~Create comparative-politics.csl (help with ibid needed)~~ Create comparative-politics.csl (work in progress) Jul 26, 2017

Update comparative-politics.csl

Loading status checks…

458e8d4

POBrien333 changed the title ~~Create comparative-politics.csl (work in progress)~~ Create comparative-politics.csl Jul 27, 2017

Update comparative-politics.csl

Loading status checks…

d227f04

Update comparative-politics.csl

Loading status checks…

7ad39ff

adam3smith reviewed Jul 30, 2017

View changes

POBrien333 added 2 commits Jul 30, 2017

Update comparative-politics.csl

Loading status checks…

3fec69f

Thanks for spotting those issues.

Update comparative-politics.csl

Loading status checks…

b7a2f9d

rmzelle merged commit 3987029 into citation-style-language:master Jul 30, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Please note that GitHub no longer supports your web browser.

citation-style-language / styles

Sponsor citation-style-language/styles

Join GitHub today

Create comparative-politics.csl #2840

Create comparative-politics.csl #2840

Conversation

POBrien333 commented Jul 25, 2017

This comment has been minimized.

csl-bot commented Jul 25, 2017

This comment has been minimized.

csl-bot commented Jul 25, 2017

This comment has been minimized.

rmzelle commented Jul 26, 2017 • edited

This comment has been minimized.

POBrien333 commented Jul 26, 2017

This comment has been minimized.

csl-bot commented Jul 26, 2017

This comment has been minimized.

csl-bot commented Jul 26, 2017

This comment has been minimized.

adam3smith commented Jul 26, 2017

This comment has been minimized.

POBrien333 commented Jul 26, 2017

This comment has been minimized.

POBrien333 commented Jul 27, 2017

This comment has been minimized.

csl-bot commented Jul 27, 2017

This comment has been minimized.

csl-bot commented Jul 27, 2017

This comment has been minimized.

rmzelle commented Jul 28, 2017

This comment has been minimized.

csl-bot commented Jul 28, 2017

adam3smith left a comment

This comment has been minimized.

adam3smith Jul 30, 2017

This comment has been minimized.

adam3smith Jul 30, 2017

This comment has been minimized.

adam3smith Jul 30, 2017

This comment has been minimized.

adam3smith Jul 30, 2017

This comment has been minimized.

csl-bot commented Jul 30, 2017

This comment has been minimized.

csl-bot commented Jul 30, 2017

This comment has been minimized.

rmzelle commented Jul 30, 2017

rmzelle commented Jul 26, 2017 •

edited