Create isabella-stewart-gardner-museum.csl #2843

POBrien333 · 2017-07-26T17:08:58Z

via https://forums.zotero.org/discussion/comment/281298/#Comment_281298

ISG Museum House Style.pdf
Crivelli Article entry 1_catalogue_final.pdf
Crivelli bibliography _catalogue_bib.pdf

Very similar, Metropolitan Museum, shows the bibliography section: Met Museum House Style.pdf

The one question is why does it not print the bracket ) at the end of the publisher section? e.g.: Walter Isaacson. Steve Jobs. (New York, NY: Simon & Schuster, 2011.


        Create isabella-steward-gardner-museum.csl

via https://forums.zotero.org/discussion/comment/281298/#Comment_281298

csl-bot · 2017-07-26T17:09:08Z

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).


        Update isabella-steward-gardner-museum.csl

csl-bot · 2017-07-26T17:09:30Z

😟 There are some issues with your submission. Please check the test report for details.

csl-bot · 2017-07-26T17:15:26Z

😟 There are some issues with your submission. Please check the test report for details.


        Update isabella-steward-gardner-museum.csl

csl-bot · 2017-07-26T17:40:02Z

😟 There are some issues with your submission. Please check the test report for details.


        Update isabella-steward-gardner-museum.csl

csl-bot · 2017-07-26T17:49:19Z

😃 Your submission passed all our automated tests.


        Update isabella-steward-gardner-museum.csl

csl-bot · 2017-07-26T21:45:09Z

😃 Your submission passed all our automated tests.

rmzelle · 2017-07-27T04:04:00Z

The one question is why does it not print the bracket ) at the end of the publisher section? e.g.: Walter Isaacson. Steve Jobs. (New York, NY: Simon & Schuster, 2011.

Are you asking why the guidelines are that way, or why the CSL style behaves that way?


        Update and rename isabella-steward-gardner-museum.csl to isabella-ste…

…wart-gardner-museum.csl

csl-bot · 2017-07-27T04:20:58Z

😃 Your submission passed all our automated tests.

POBrien333 · 2017-07-27T04:29:57Z

Why the style behaves like that.
Also, you did see the two other files I posted in this PR? One is a bibliographic section from the end of a book of theirs (they have notes at the end of a "chapter" and then all the references in one big section at the end).


        Update isabella-stewart-gardner-museum.csl

POBrien333 · 2017-07-27T14:33:52Z

isabella-stewart-gardner-museum.csl

+            <text macro="volume-and-collection-title"/>
+            <text macro="edition"/>
+          </group>
+          <group delimiter=", " prefix=" (" suffix=")">


@rmzelle
These closing brackets here do not appear for me :(
Looks like this: Walter Isaacson. Steve Jobs. (New York, NY: Simon & Schuster, 2011.
Should be: Walter Isaacson. Steve Jobs. (New York, NY: Simon & Schuster, 2011).

Is that in Mendeley? Visual Editor?

Visual Editor. I don't use Mendeley anymore. No use for it since I left academia ;)

I'm seeing this too in Zotero Standalone 4.0.29.17. If I remove the `display="block" it goes away. See the stripped down version at https://gist.github.com/rmzelle/e135ac9b7d6aaf6c6a2e5c99b3a55282.

Note that the specification says: "The display attribute (similar the “display” property in CSS) may be used to structure individual bibliographic entries into one or more text blocks. If used, all rendering elements should be under the control of a display attribute."

Putting display="block" on the second group fixes the issue for me: https://gist.github.com/rmzelle/f54671436636b0e5d326c175f092f641

csl-bot · 2017-07-27T14:39:00Z

😟 There are some issues with your submission. Please check the test report for details.


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-07-27T14:58:43Z

😃 Your submission passed all our automated tests.


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-07-27T15:32:32Z

😃 Your submission passed all our automated tests.

rmzelle · 2017-07-28T01:31:10Z

Also, you did see the two other files I posted in this PR?

Yes, but I only briefly looked at them. Is there anything about them that I should be aware off in reviewing this CSL style?

(also, did you receive scans of the front matter that I requested of the requestor (at https://forums.zotero.org/discussion/comment/281406#Comment_281406)? I just want to make sure we name this style correctly, and that we have the bibliographic details on hand of the style guide in case we need to track it down in the future)

POBrien333 · 2017-07-28T09:27:28Z

No, didn't get anything more sent via email. Let's wait and see.


        Update isabella-stewart-gardner-museum.csl


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-08-09T14:35:17Z

😟 There are some issues with your submission. Please check the test report for details.

csl-bot · 2017-08-09T14:37:34Z

😟 There are some issues with your submission. Please check the test report for details.


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-08-09T15:20:37Z

😃 Your submission passed all our automated tests.

rmzelle · 2017-08-09T15:26:35Z

@POBrien333, can you attach those additional files you received (especially the title page)? Also let me know if this should be good to merge.


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-08-10T13:47:11Z

😟 There are some issues with your submission. Please check the test report for details.


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-08-10T14:22:27Z

😃 Your submission passed all our automated tests.


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-08-15T16:52:33Z

😃 Your submission passed all our automated tests.


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-08-16T09:42:17Z

😃 Your submission passed all our automated tests.


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-08-16T16:05:19Z

😃 Your submission passed all our automated tests.

rmzelle · 2017-08-22T03:36:16Z

(is this in good enough shape to merge right now? You can always submit a follow-up PR)

POBrien333 · 2017-08-22T13:07:14Z

Let me send her an email. She never replied back on the forum. I think it still has some kinks to fix though.

POBrien333 · 2017-09-04T16:58:31Z

Closing this, as I don't want to spend more time on this than I have already.

adam3smith · 2017-09-04T16:59:59Z

wouldn't it make sense to take it as is, though? It seems like it's pretty close.

POBrien333 · 2017-09-04T17:00:53Z

if you want to, go ahead. :)

rmzelle · 2017-09-04T23:29:14Z

I don't want to spend more time on this than I have already.

That's fine, of course. Did you tell the requestor?


        Update isabella-stewart-gardner-museum.csl

csl-bot · 2017-09-04T23:35:07Z

😃 Your submission passed all our automated tests.

csl-bot · 2017-09-04T23:37:15Z

😃 Your submission passed all our automated tests.

rmzelle · 2017-09-04T23:38:05Z

And thanks!

Create isabella-steward-gardner-museum.csl

Loading status checks…

f575cb5

via https://forums.zotero.org/discussion/comment/281298/#Comment_281298

Update isabella-steward-gardner-museum.csl

Loading status checks…

25580f2

Update isabella-steward-gardner-museum.csl

Loading status checks…

6b94937

Update isabella-steward-gardner-museum.csl

Loading status checks…

d8cebe6

Update isabella-steward-gardner-museum.csl

Loading status checks…

21cc2f5

Update and rename isabella-steward-gardner-museum.csl to isabella-ste…

Loading status checks…

77fb8d5

…wart-gardner-museum.csl

rmzelle changed the title ~~Create isabella-steward-gardner-museum.csl~~ Create isabella-stewart-gardner-museum.csl Jul 27, 2017

Update isabella-stewart-gardner-museum.csl

Loading status checks…

c7e6b20

POBrien333 reviewed Jul 27, 2017

View changes

Update isabella-stewart-gardner-museum.csl

Loading status checks…

fee954d

Update isabella-stewart-gardner-museum.csl

Loading status checks…

afd1e22

POBrien333 added 2 commits Aug 9, 2017

Update isabella-stewart-gardner-museum.csl

Loading status checks…

8d77a89

Update isabella-stewart-gardner-museum.csl

Loading status checks…

2850371

Update isabella-stewart-gardner-museum.csl

Loading status checks…

378fb2d

Update isabella-stewart-gardner-museum.csl

Loading status checks…

3bd8cce

Update isabella-stewart-gardner-museum.csl

Loading status checks…

ebb4336

Update isabella-stewart-gardner-museum.csl

Loading status checks…

773a085

Update isabella-stewart-gardner-museum.csl

Loading status checks…

a4dab4f

Update isabella-stewart-gardner-museum.csl

Loading status checks…

f7db4d7

POBrien333 closed this Sep 4, 2017

rmzelle reopened this Sep 4, 2017

Update isabella-stewart-gardner-museum.csl

Loading status checks…

e4345e1

rmzelle merged commit 4e3948c into citation-style-language:master Sep 4, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Please note that GitHub no longer supports your web browser.

citation-style-language / styles

Sponsor citation-style-language/styles

Join GitHub today

Create isabella-stewart-gardner-museum.csl #2843

Create isabella-stewart-gardner-museum.csl #2843

Conversation

POBrien333 commented Jul 26, 2017 • edited

This comment has been minimized.

csl-bot commented Jul 26, 2017

This comment has been minimized.

csl-bot commented Jul 26, 2017

This comment has been minimized.

csl-bot commented Jul 26, 2017

This comment has been minimized.

csl-bot commented Jul 26, 2017

This comment has been minimized.

csl-bot commented Jul 26, 2017

This comment has been minimized.

csl-bot commented Jul 26, 2017

This comment has been minimized.

rmzelle commented Jul 27, 2017

This comment has been minimized.

csl-bot commented Jul 27, 2017

This comment has been minimized.

POBrien333 commented Jul 27, 2017 • edited

This comment has been minimized.

POBrien333 Jul 27, 2017 • edited

This comment has been minimized.

rmzelle Jul 27, 2017

This comment has been minimized.

POBrien333 Jul 27, 2017

This comment has been minimized.

rmzelle Jul 27, 2017

This comment has been minimized.

csl-bot commented Jul 27, 2017

This comment has been minimized.

csl-bot commented Jul 27, 2017

This comment has been minimized.

csl-bot commented Jul 27, 2017

This comment has been minimized.

rmzelle commented Jul 28, 2017 • edited

This comment has been minimized.

POBrien333 commented Jul 28, 2017

This comment has been minimized.

csl-bot commented Aug 9, 2017

This comment has been minimized.

csl-bot commented Aug 9, 2017

This comment has been minimized.

csl-bot commented Aug 9, 2017

This comment has been minimized.

rmzelle commented Aug 9, 2017

This comment has been minimized.

csl-bot commented Aug 10, 2017

This comment has been minimized.

csl-bot commented Aug 10, 2017

This comment has been minimized.

csl-bot commented Aug 15, 2017

This comment has been minimized.

csl-bot commented Aug 16, 2017

This comment has been minimized.

csl-bot commented Aug 16, 2017

This comment has been minimized.

rmzelle commented Aug 22, 2017

This comment has been minimized.

POBrien333 commented Aug 22, 2017

This comment has been minimized.

POBrien333 commented Sep 4, 2017

This comment has been minimized.

adam3smith commented Sep 4, 2017

This comment has been minimized.

POBrien333 commented Sep 4, 2017

This comment has been minimized.

rmzelle commented Sep 4, 2017

This comment has been minimized.

csl-bot commented Sep 4, 2017

This comment has been minimized.

csl-bot commented Sep 4, 2017

This comment has been minimized.

rmzelle commented Sep 4, 2017

POBrien333 commented Jul 26, 2017 •

edited

POBrien333 commented Jul 27, 2017 •

edited

POBrien333 Jul 27, 2017 •

edited

rmzelle commented Jul 28, 2017 •

edited