Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create iso690-author-date-no-abstract-en.csl #3259

Merged
merged 6 commits into from Mar 16, 2018

Conversation

@paezm
Copy link
Contributor

paezm commented Jan 12, 2018

I change the style iso-690-author-date-en.csl. In this version, the abstract has been removed. And instead of "Accessed 9 November 2016" I changed by "Viewed 9 November 2016".

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 12, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 12, 2018

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 12, 2018

What guide exactly is this based on? "ISO 690" is such a vague reference -- providing more general guidance than a specific citation format -- that I'd like to prevent the proliferation of styles. E.g., "Viewed" vs. "Accessed" certainly isn't something that the ISO standard specifies, is it?

@paezm

This comment has been minimized.

Copy link
Contributor Author

paezm commented Jan 12, 2018

ISO 690:2010. My library school wrote a guide about this style https://www.hesge.ch/heg/infotheque/citations-et-references-bibliographiques.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 12, 2018

Great, thanks -- since this is only "based on" ISO 690:2010, I think we'll want to name this after the school rather than ISO 690. Looking briefly at the guide, I think it also makes sense to remove the note and archive macro and the block display?

@paezm

This comment has been minimized.

Copy link
Contributor Author

paezm commented Jan 12, 2018

Sorry but I'm not sure I understand. It's better if I change the name ? And I add the School library name?
Is it neccessary to remove the note and archive macro and the block display ? :)

@paezm

This comment has been minimized.

Copy link
Contributor Author

paezm commented Jan 15, 2018

It's better if we keep the name iso-690 because many schools use this standard. Et we have respected this standard. It's really specified "viewed" and not "accessed". How should I proceed to have the style validated? Sorry, this is the first time I'm correcting a style.. ;)

…e-de-gestion-de-geneve-iso-690.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 16, 2018

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 16, 2018

I renamed the style to what we'd typically do in these cases. We could add back the "author-date" descriptor if your institution uses more than one type of ISO 690 style (like the "numeric" or "note" versions). The style is currently fixed to US English, so I added the language to the title as well (it might be possible to support both a French and an English version of the style with a single style file).

@paezm

This comment has been minimized.

Copy link
Contributor Author

paezm commented Jan 16, 2018

Thank you @rmzelle

…te-ecole-de-gestion-de-geneve-iso-690-eng.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 1, 2018

😟 There are some issues with your submission. Please check the test report for details.

… haute-ecole-de-gestion-de-geneve-iso-690.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 2, 2018

😃 Your submission passed all our automated tests.

@paezm

This comment has been minimized.

Copy link
Contributor Author

paezm commented Feb 3, 2018

@rmzelle Now, my style is submitted ?
How to display my style on www.zotero.org/styles?

@paezm

This comment has been minimized.

Copy link
Contributor Author

paezm commented Feb 20, 2018

@adam3smith Hi ! How to display my style on www.zotero.org/styles?

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 15, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 15, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit bcaad2e into citation-style-language:master Mar 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 16, 2018

Thanks!

@paezm

This comment has been minimized.

Copy link
Contributor Author

paezm commented Mar 26, 2018

Thank you!!! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.