Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for conditions with multiple type values without match="any" #3407

Merged

Conversation

@customcommander
Copy link
Contributor

customcommander commented Mar 28, 2018

Fixes #3405

I found two other cases which are more difficult to fix. I didn't touch those as adding match="any" would perhaps not be what the authors of these styles meant. (Better to let them fix that IMO.)

Example here and here:

<if variable="URL" type="webpage post-weblog">

I also found these two other cases but I'm not entirely sure whether they are mistakes. (Just letting you know in case they are.)

In university-college-lillebaelt-vancouver.csl:

<if type="legislation bill"/>

And in uppsala-universitet-historia.csl:

<if is-numeric="edition" type="book article"/>
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 28, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 28, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 149a664 into citation-style-language:master Mar 28, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 28, 2018

Thanks so much!
Yes, the above examples are also all mistakes but fixing them (except for the lillebaelt one) requires nesting the conditions (in any order) so probably needs to be done by hand. If you want to handle those too, that'd be amazing, otherwise we can take those.

@customcommander customcommander deleted the customcommander:any-types branch Mar 29, 2018
@customcommander customcommander mentioned this pull request Mar 29, 2018
@adam3smith adam3smith mentioned this pull request Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.