Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create urban-geography.csl #3570

Merged
merged 4 commits into from Jul 2, 2018

Conversation

@POBrien333
Copy link
Contributor

POBrien333 commented Jun 28, 2018

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jun 28, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jun 28, 2018

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jun 30, 2018

😃 Your submission passed all our automated tests.

Copy link
Member

adam3smith left a comment

Some quick comments. Didn't fix myself because I wasn't sure about the order of substitute elements.

<substitute>
<text variable="container-title"/>
<text variable="collection-title"/>
<names variable="editor"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jun 30, 2018

Member

It seems really odd to not have editor at the top here -- are you sure, especially vis-a-vis collection-title? (And it is at the top in the author-short macro.

<if type="thesis article book" match="any" variable="event">
<text variable="title" font-style="italic"/>
</if>
<else-if type="article-newspaper" match="any">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jun 30, 2018

Member

remove; this doesn't do anything.

<macro name="container">
<group>
<choose>
<if type="chapter entry-encyclopedia" match="any">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jun 30, 2018

Member

typically also: paper-conference

<choose>
<if type="article-journal chapter paper-conference" match="none">
<names variable="translator editor" delimiter=", " prefix=" (" suffix=")">
<name and="symbol" initialize-with=". " delimiter=", "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jun 30, 2018

Member

having container contributors not initialized and secondary contributors initialized seems odd.

</group>
</layout>
</citation>
<bibliography et-al-min="8" et-al-use-first="7" et-al-use-last="true" entry-spacing="0" line-spacing="2" hanging-indent="true">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jun 30, 2018

Member

should be et-al-use-first="6" ("use the first six")

POBrien333 added 2 commits Jul 2, 2018
Thanks for finding those errors! :)
Fix issue as found in style based on this one.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 2, 2018

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 2, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 8de750d into citation-style-language:master Jul 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jul 2, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.